alessioalex / dynroute Goto Github PK

If I turn dbg option on, I get the below error. Without the debug option, everything works fine.

shell> dynroute -d some.domain.com -o -dbg

/volume1/@appstore/node/lib/node_modules/dynroute/dynroute.js:109
if (domain.indexOf(zone.name) > -1) {
^
TypeError: Object true has no method 'indexOf'
at updateDns.zoneId (/volume1/@appstore/node/lib/node_modules/dynroute/dynroute.js:109:26)
at Array.forEach (native)
at iterate (/volume1/@appstore/node/lib/node_modules/dynroute/dynroute.js:108:25)
at hostedZones.forEach.rootZone (/volume1/@appstore/node/lib/node_modules/dynroute/dynroute.js:99:15)
at process._tickCallback (node.js:415:13)

It doesn't pick the right one, it selects the first one all the time.

Any thoughts on how to get this to work with the private (in-VPC, or in EC2) IP rather than the web public IP?

Example function here (maybe make a small npm module out of it):

https://github.com/chjj/tty.js/blob/master/lib/config.js#L232-L250

.

Hopefully people won't use their admin account for every operation on aws. Would appreciate if you can update the readme.

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "route53:ListHostedZones",
                "route53:ListResourceRecordSets",
                "route53:ChangeResourceRecordSets",
                "route53:CreateHostedZone",
                "route53domains:*"
            ],
            "Resource": [
                "*"
            ]
        }
    ]
}

Default to something more reliable than whatismyip.nodejitsu.com

It seems that http://ip-address.herokuapp.com/ip.json is no longer available, but there is a new service at https://api.ipify.org?format=json with the same result format (info here; it claims to be here for a while). You may want to update the default.

there are a couple of instance of

util.exit(errMsg);

which are actually referencing the built-in util library, but I think the intention is to reference the .exit() function defined in the module itself.

A fix would be to do something like this:

var ns = {};

ns.exit = function(s){
   //...
};

ns.otherFunction = function(){
   //...
   if (err){ 
      ns.exit("got an error"); 
   }
};

module.exports = ns;

https://github.com/awssum/awssum-amazon-route53

Its only using the hardcoded default ~/.awsrc

(great package by the way!)