This code is valid

I'm removing the include statement and of course it throws a lot of errors

But after I place include statement again (e.g. undo action)

Developer: Reload window solves the problem and this code becomes like at the first picture

Some Clang-tidy checks are designed specially for Objective-C (search for objc https://clang.llvm.org/extra/clang-tidy/checks/list.html), so it'll be reasonable to allow this extension to work for Objective-C files.

When fixing clang-tidy warnings, the last warning is never removed. It requires closing vscode and reopening to make it disappear.

Hi, i realized that this plugin is very useful when you want to improve code quality.
But it has a very annoying problem.
when you click on an error you get "file not found"
This plugin becomes unusable as a result since it just ends up using alot of cpu resources and in the end you don't get much out of it.
Kindly help us fix this error, i've tried going through the source code , attempted to modify diagnostic report to change file lines and even tried out some pull requests which were better but none of them fixes that bug.

I'd be nice to have an option to filter-out files that shall not be lint, e.g. generated files, 3rd party files etc. They're commonly opened but never edited hence there's no option to actually change them

the specific error:
"'stdlib.h' file not found (clang-diagnostic-error)"

{
	"resource": "/c:/Users/MassiveAtoms/Desktop/misc-lang/dailyprogrammer374/easy/additive_persistence.cpp",
	"owner": "_generated_diagnostic_collection_name_#3",
	"severity": 8,
	"message": "'stdlib.h' file not found (clang-diagnostic-error)",
	"source": "Clang Tidy",
	"startLineNumber": 50,
	"startColumn": 1,
	"endLineNumber": 50,
	"endColumn": 1
}

vscode setup

Version: 1.31.1 (user setup)
Commit: 1b8e8302e405050205e69b59abb3559592bb9e60
Date: 2019-02-12T02:20:54.427Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

here are the used clangTidy entries in my settings.json:

    "clangTidy.executable": "C:\\msys64(4clang)\\mingw64\\bin\\clang-tidy.exe",
    "clangTidy.systemIncludePath": [
        "C:\\msys64(4clang)\\mingw64\\lib\\clang\\7.0.1\\include",
        "C:\\msys64(4clang)\\mingw64\\x86_64-w64-mingw32\\include",
        "C:\\msys64(4clang)\\mingw64\\include",
        "C:/msys64(4clang)/mingw64/include/c++"
    ],
    "clangTidy.lintLanguages": [
        "cpp"
    ],

A quick search with everything from voidtools shows that there is indeed a stdlib.h in
C:\msys64(4clang)\mingw64\x86_64-w64-mingw32\include , which is one of the paths in "clangTidy.systemIncludePath" and in "C_Cpp.default.systemIncludePath"

C:\Users\MassiveAtoms>es stdlib.h path:C:\msys64(4clang)\mingw64\
C:\msys64(4clang)\mingw64\include\c++\8.2.1\stdlib.h
C:\msys64(4clang)\mingw64\include\c++\8.2.1\tr1\stdlib.h
C:\msys64(4clang)\mingw64\x86_64-w64-mingw32\include\stdlib.h

(On master branch) If you include files relative to the workspace folder, the extension stitches the path together with the path to the currently opened file. Resulting in an incorrect path.

when my source file contains some character like chinese word "哈"，it will be recognized by clang-tidy as three bytes offset, but when fix some naming error in vscode ediator, the offset will be calculated into start:{line:, character:} . but at this time, "哈" will only be recognized as one bytes offset, which results replace bias error.

The compilerargs should at least be per language. Otherwise clang tidy doesn't allow setting a C and C++ standard at the same time.

Hi,

The "clangTidy.xxx" settings do not provide adequate support for configuring clang-tidy for a workspace. In particular, I need support for clang-tidy "-p" option to point it at the "compile_commands.json" file generated by CMake. More broadly speaking, there should be settings to control additional arguments passed to clang-tidy; akin to "clangTidy.extraCompilerArgs", but for clang-tidy, not the compiler.

This boils down to the following command line:
clang-tidy -p <cmake-buid-directory> <target-source-file>

Thanks.

If you use ${workspaceFolder} when specifying the clangTidy.executable path the variable is not resolved, for example ${workspaceFolder}/tools/llvm/bin/clang-tidy. This is useful for cases when clang-tidy is installed locally within the work-space. The list of variables that are usable are defined here.

I believe the change is done by calling resolve() here:

It looks like resolve() is defined here, but this is a base class and I'm unsure of the proper way to access it in vs-code extensions.

Current npm packages contain 8 known vulnerable packages. Can be fixed with npm audit fix.

The plugin should only launch a new instance of clangtidy if the previous one has finished to reduce cpu usage when user saves a file multiple times in succession.

I get a large amount of errors on the last line of every file. There's nothing on this line, and it's unclear what this is referring to.

Hi, This extension would be very useful in vs-code.
If we can setup a donation system so that devs can spare sometime to actually work on it and get something for using their time.

One major thing missing from the extension is the ability to ignore warnings from included files. If you try using it on any project that includes Gtk+ or Gtkmm headers, you can easily have over 20000 warnings on what amounts to basically system headers.

Considering that the extension runs clang-tidy on the currently opened files, maybe it would make sense to pass -line-filter='[{"name":"<filename>"}]' to clang-tidy (where <filename> is the file's name) to filter out everything at once.

Issue: when clang-tidy finds an issue, it is printed to the 'problems' tab in visual studio code. Once the issue is resolved, the issue is still visible in the 'problems' view.

Proposed resolution: remove existing issues for the file being analyzed before analyze. If the issue was resolved, it will not be presented to the user. If the issue is still there, the clang-tidy will raise the issue. According to vscode team, this is responsibility of the plugin to remove old 'issues in 'problems' window (see microsoft/vscode#15524)