Git Product home page Git Product logo

rental-of-property's Introduction

Rental-of-property

rental-of-property's People

Contributors

alejinjer avatar gloomikon avatar

Watchers

 avatar  avatar  avatar

rental-of-property's Issues

Incorrect work of PUT method

@PutMapping("/apartments")
public Boolean editApartment(@RequestBody @RequestParam(value = "id", required = true) Integer id,
                             @RequestParam(value = "flats_number", required = true) Integer flats_number,
                             @RequestParam(value = "cost", required = true) Integer cost,
                             @RequestParam(value = "description", required = true) String description,
                             @RequestParam(value = "address", required = true) String address,
                             @RequestParam(value = "img_url", required = true) String img_url) {
    try {
        Optional<Apartment> test = apartmentRepository.findById(id);
        if (!test.isPresent())
            return false;
        Apartment apartment = new Apartment(flats_number, cost, description, address, img_url);
        apartmentRepository.save(apartment);
        return true;
    } catch (Exception e) {
        return false;
    }
}

I think this code must be sth like that:

Optional<Apartment> test = apartmentRepository.findById(id);
            if (!test.isPresent())
                return false;
            Apartment apartment = test.get();
            apartment.setFlatsNumber(flats_number);
            apartment.setCost(cost);
            apartment.setDescription(description);
            apartment.setImgUrl(img_url);
            apartmentRepository.save(apartment);
            return true;

In previous case, it created a new apartment!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.