alanmcna / maharadroid Goto Github PK

Currently the app splits multiple file uploads into a collection of single 
uploads and duplicates shared settings (journal name, entry, tags, etc). 

The api checks (on each upload - rather than just ones known to be multiples ;) 
if a duplicate post (by title/entry) already exists. If one does then the 
uploaded file is attached to the existing entry.

a) ideally pass additional (Part) and (Count) parameters in the post if the 
entry is part of a multiple upload. 

b) the api should if (Part) check for existing Journal post with provided 
details.

c) The api should not check if (Part) not provided - reducing load.

Start MaharaDroid .. change your token and the app closes.

Should remain open allowing further editing.

Go into contacts .. long press .. share and select MaharaDroid .. the 
application crashes

The problem seems to be with permissions...

10-28 20:17:55.986: DEBUG/ArtifactSettings(15841): Upload Conditions Confirmed: 
true
10-28 20:17:55.996: DEBUG/ArtifactSettings(15841): URI = 
'content://com.android.contacts/contacts/as_vcard/3565i70f8117308eae079'
10-28 20:17:56.006: ERROR/DatabaseUtils(15875): Writing exception to parcel
10-28 20:17:56.006: ERROR/DatabaseUtils(15875): java.lang.SecurityException: 
Permission Denial: reading com.android.providers.contacts.ContactsProvider2 uri 
content://com.android.contacts/contacts/as_vcard/3565i70f8117308eae079 from 
pid=15841, uid=10066 requires android.permission.READ_CONTACTS
10-28 20:17:56.006: ERROR/DatabaseUtils(15875):     at 
android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.
java:271)
10-28 20:17:56.006: ERROR/DatabaseUtils(15875):     at 
android.content.ContentProvider$Transport.bulkQuery(ContentProvider.java:149)
10-28 20:17:56.006: ERROR/DatabaseUtils(15875):     at 
android.content.ContentProviderNative.onTransact(ContentProviderNative.java:111)
10-28 20:17:56.006: ERROR/DatabaseUtils(15875):     at 
android.os.Binder.execTransact(Binder.java:288)
10-28 20:17:56.006: ERROR/DatabaseUtils(15875):     at 
dalvik.system.NativeStart.run(Native Method)

I have put all the settings within MaharaDroid, when I try to upload an image.

Android 4.4.2
Maharadroid 1.8

v1.7 - Aug 9, 2011 10:45:48 AM - 0 reports/week 

java.lang.RuntimeException: Unable to start activity 
ComponentInfo{nz.net.catalyst.MaharaDroid/nz.net.catalyst.MaharaDroid.ui.Artifac
tSettingsActivity}: java.lang.NullPointerException
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2663)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2679)
at android.app.ActivityThread.access$2300(ActivityThread.java:125)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2033)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:123)
at android.app.ActivityThread.main(ActivityThread.java:4627)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:521)
at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.NullPointerException
at nz.net.catalyst.MaharaDroid.Utils.canUpload(Utils.java:64)
at 
nz.net.catalyst.MaharaDroid.ui.ArtifactSettingsActivity.onCreate(ArtifactSetting
sActivity.java:117)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2627)
... 11 more

Application could support dynamic resize and post of content prior to upload to 
reduce impact on server (server processing upload and storage of large files).

Currently the lastsync time is recorded on the device .. we then ask the server 
for anything new since this last time. The problem is this is the time on the 
device which may be in a different timezone / locale (users don't often set 
this 100% accurately on mobiles). 

To fix this - get the sync api to respond with the current server time which we 
can save and use it's time as the offset - the devices time is irrelevant.

Token based authentication is a easy first step for simple upload. If any more 
complicated read/write app to server communication is required then a more 
complete authentication mechanism could be looked at OAuth might be a good 
choice here.

Share MaharaDroid only appears for images.

Nice to have the option to set a artefact description

Exception class
java.lang.NullPointerException

Source method
RestClient.UploadArtifact()

java.lang.RuntimeException: An error occured while executing doInBackground()
at android.os.AsyncTask$3.done(AsyncTask.java:200)
at java.util.concurrent.FutureTask$Sync.innerSetException(FutureTask.java:273)
at java.util.concurrent.FutureTask.setException(FutureTask.java:124)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:307)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1068)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:561)
at java.lang.Thread.run(Thread.java:1096)
Caused by: java.lang.NullPointerException
at nz.net.catalyst.MaharaDroid.RestClient.UploadArtifact(RestClient.java:117)
at 
nz.net.catalyst.MaharaDroid.TransferService$UploadArtifactTask.doInBackground(Tr
ansferService.java:111)
at 
nz.net.catalyst.MaharaDroid.TransferService$UploadArtifactTask.doInBackground(Tr
ansferService.java:1)
at android.os.AsyncTask$2.call(AsyncTask.java:185)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
... 4 more

Once accepted - just save the fact that they have accepted

I know this is a big ask, but it would be really useful to be able to write 
journal entries within the MaharaDroid app. This would allow offline creation 
of journal entries.

Nice to be able to add tags to artefact on upload

Currently the sync API looks for any unread message and raises a notification 
(new since last sync). 

Ideally the application should have support for user selectable notification 
types.

Consider raising a notification if new sync tags, journals, etc are received.

Would be good to auto-create a public view 

Something like http://master.dev.mahara.org/view/view.php?id=428).

Tags are not added until the next sync is performed. So consider forcing a 
one-time sync after the upload queue (if non-empty) is emptied.

v1.7 - Aug 17, 2011 9:50:16 PM - 0 reports/week - 2 reports

java.lang.RuntimeException: Unable to start activity 
ComponentInfo{nz.net.catalyst.MaharaDroid/nz.net.catalyst.MaharaDroid.ui.Artefac
tExpandableListAdapterActivity}: 
android.database.CursorIndexOutOfBoundsException: Index 0 requested, with a 
size of 0
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2787)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2803)
at android.app.ActivityThread.access$2300(ActivityThread.java:135)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2136)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:144)
at android.app.ActivityThread.main(ActivityThread.java:4937)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:521)
at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:868)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:626)
at dalvik.system.NativeStart.main(Native Method)
Caused by: android.database.CursorIndexOutOfBoundsException: Index 0 requested, 
with a size of 0
at android.database.AbstractCursor.checkPosition(AbstractCursor.java:580)
at 
android.database.AbstractWindowedCursor.checkPosition(AbstractWindowedCursor.jav
a:214)
at 
android.database.AbstractWindowedCursor.getString(AbstractWindowedCursor.java:41
)
at android.database.CursorWrapper.getString(CursorWrapper.java:140)
at nz.net.catalyst.MaharaDroid.Utils.getFilePath(Utils.java:89)
at 
nz.net.catalyst.MaharaDroid.ui.ArtefactExpandableListAdapterActivity.loadSavedAr
tefacts(ArtefactExpandableListAdapterActivity.java:135)
at 
nz.net.catalyst.MaharaDroid.ui.ArtefactExpandableListAdapterActivity.onCreate(Ar
tefactExpandableListAdapterActivity.java:96)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1069)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2751)
... 11 more

What steps will reproduce the problem?
1. Create a file with a space in the file name
2. Upload the file

What is the expected output? What do you see instead?
Error message regarding cannot access file (on device .. file://sd/etc)

v1.7 - Jul 9, 2011 1:51:36 AM - 0 reports/week 

java.lang.RuntimeException: Unable to resume activity 
{nz.net.catalyst.MaharaDroid/nz.net.catalyst.MaharaDroid.ui.ArtefactExpandableLi
stAdapterActivity}: java.lang.IllegalStateException: trying to requery an 
already closed cursor
at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2215)
at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:2243)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1019)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:126)
at android.app.ActivityThread.main(ActivityThread.java:3997)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:491)
at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:841)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:599)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.IllegalStateException: trying to requery an already closed 
cursor
at android.app.Activity.performRestart(Activity.java:4343)
at android.app.Activity.performResume(Activity.java:4366)
at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2205)
... 10 more

reported by Shane Nuessler at https://bugs.launchpad.net/mahara/+bug/1280062

It would be great if you were able to upload a file directly into one of your 
groups.

On HTC Desire when the phone is in landscape mode, only the fields for file 
name and description are shown. Tags can be entered but barely. I can't get to 
the "Done" button but have to switch to portrait mode.

Can only upload into 'Home' folder

Currently Utils.updateListPreferenceFromJSON deletes and re-inserts all new 
sync'ed tags/folders, etc .. ideally, either
a) the sync API should return only changes since last request (proper sync 
api),or
b) the app needs to be smart enough to make old items - add new ones and delete 
no items no longer present.

From main or details UI select options - camera and take a photo .. there is no 
effect on operation the image is not passed or is the image changed.

Either get it operational or drop from current release

A Mahara styled dialog containing help text 

Report on https://bugs.launchpad.net/mahara/+bug/1268786 :

This is an issue as a fresh user has no tags, workaround is to make a single 
tag, which then fixes it, error log below

 [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] [WAR] 88 (api/mobile/sync.php:77) Invalid argument supplied for foreach()
 [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] Call stack (most recent first):
 [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] * log_message("Invalid argument supplied for foreach()", 8, true, true, "/home/demo/code/mahara/htdocs/api/mobile/sync.php", 77) at /home/demo/code/mahara/htdocs/lib/errors.php:430
 [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] * error(2, "Invalid argument supplied for foreach()", "/home/demo/code/mahara/htdocs/api/mobile/sync.php", 77, array(size 59)) at /home/demo/code/mahara/htdocs/api/mobile/sync.php:77
 [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88]

If the username is changed we need to remove any existing accounts before 
trying to authenticate / create a new one. 

It is confusing for the user to have to try and do this themselves.

1. In a test scenario (overnight) wifi access was maintained. 
2. New items have been saved (if uploadable state)
3. Last sync remains as previous evening at 22:25 

Question.. when does a new sync occur? Ideally the device should try and sync 
(or check if it Utils.canUpload more often).

nice to have default 'Android' or similar tags set on preference screen (per 
artefact tags would be added to these default ones)

If you enter an Upload URI which is an actual webpage, but not a mahara 
mobileupload page, MaharaDroid gets an http OK status code, reports that your 
file was uploaded successfully, and resets its token to the html contents of 
that page.

In the next version, Mahara should probably return something with a bit of 
structure (json object?), with its own status code, message, token, etc., so 
MaharaDroid can report a useful error if it receives something unexpected.

[You don't actually have to mistype the URI to have this problem, any kind of 
redirect to a valid page will do it, for example if your phone connects to an 
open but paid wifi network that redirects all requests to a "top up your data" 
page.]

What steps will reproduce the problem?
1. Enter an invalid URL as a Mahara upload URL
2. Upload a file

An IllegalArgumentException is raised in RestClient when 
httpclient.execute(httppost);