jacking_qality?????

This should have been done before I decided to touch stuff. But I didn't and then proceeded to feel the wrath and pain of not doing so. This needs to be done to a) verify temperatures are actually working as expected currently b) prevent breaking it in the future.

With the tests in place that can appropriately model the behavior we want, some attempt can be made to at least fix the worst offenders.

The entire thread here and specifically Kevin's comment here CleverRaven#20414 (comment) describes some basic sanity tests that should absolutely not be the case.

These names are perversions of the traditional nomenclature that makes stubborn people argue over the semantics of whether or not they should be defined as negative values.

Just make them Z_MIN/Z_MAX and end it.

This shit is a mess and it would be a great target to clear up game.cpp junk. player::siphon doesn't really need to be there either.

Looking at all the functions involved and their dependencies, I don't see any reason they actually need to be part of the game interface.

why does tiles get all the fun? ascii peeps want a minimap too

The recipe menu could really use some QoL love. It works, but barely.

Acceptance Criteria

• Walk through the code and get a gist of how it works
• Come up with some rough ideas of how it can be improved
• Setup project outlining what needs to be done
• Break up tasks into issues and put into project

There's a report of the initial spawn on wander being doubled or something strange. Should check it out

When running multiple tests in parallel you fun errors like this:

It's probably not a big deal but it might be an easy fix and it could theoretically be an issue for the multiple instance use case.

With tests and some data to backup tests, everything can be cleaned up and submitted for code review.

CleverRaven#25182

There's some legit issues here but it needs to be broken up. It doesn't look like that was ever done, so whenever I get around to this check if they still haven't and create them if not.

At the very least it should be using an LRU, probably some kind of modified version of it to cache memory better.

There's also some bugs with looks_like

I think there's some huge performance benefits to be found. I need to setup a project and iterate through what needs to be done to address it.

I noticed visit_items get iterated through constantly while just idling. Kevin suggested it's the animation loop looking through the items to animate.

What I think can solve this is adding some kind of cache representation for the animation loop of what it needs to animate instead of having it iterate each and every single item that could possibly be displayed. Given a large number items this could theoretically slow processing to a crawl.

Take a swing at this thing: CleverRaven#20414

This probably requires an entire project to setup and do.

At a minimum, tests for the current state of the game and such need to be added. From there, rebalancing can occur but not before.

I honestly don't even know what's in crazy cataclysm, but this gun is so awesome I can't not add it.

With tests in place and modified to model behavior that we want, some attempt can be to triage the issue. A full solution is not required here, but the basic sanity tests at a minimum should pass.

CleverRaven#20414 (comment)

The debug mapgen menu is a little rough around the edges. It has everything you need to get the job done but it's not always obvious or easy what it's asking.

I need to setup a project and iterate through what can be done to improve it.

We need some kind of baseline to test against so that when an attempt is made to treat the issue, it can be demonstrated in a functional way.

Additionally by having these tests in place, they can be used for future balancing if required.

• Iron javelin looks like the best candidate for an upper bound on throwing items

  Cataclysm-DDA/data/json/items/melee.json

  Line 1010 in 981effa

  "thrown_damage": [ { "damage_type": "bash", "amount": 5 }, { "damage_type": "stab", "amount": 17 } ],

• Maybe something like a rock as a lower bound? Or maybe something super light like a cash card?
• Need to test at different ranges and different skill levels
• Compare against other weapons like pistols
• CleverRaven#20414 (comment)

I somehow accidentally added a save/templates/and config directories to my ./tests/ directory and everything exploded.

It's fine if that fails but it needs to tell me why.