aksem / adaptagrams Goto Github PK

Actual: In a hierarchical diagram if two child shapes are connected with each other, connections between them go outside of the parent.

Expected: optimal connection inside of the parent.

Currently, equivalent routes can have different positions after multiple runs.

HierarchicalOrthogonalRouter_TwoChildrenVerticallyAllWithPins test can be used as demonstration.

For example inner routes are equivalent and after one run the shorter one can be left, after another run right.

Deterministic routes would improve behaviour of the router and make testing easier, because there would be no need to include all equivalent routes and check their combinations.

Example:

After removing the top edge, bottom one stays on its place, however should be moved to the center:

The only way to move ShapeConnectionPin is to re-create it with another position. To avoid unneeded actions a method to change the position of ShapeConnectionPin would be very helpful. And it exists already but is private.

I assume the easiest solution is to make it public & cover it with tests to check that it works correctly.