akkadius / spire Goto Github PK

Requesting that the default Goal Count be 1 (currently 5) when creating a new task activity. A count of 1 is the most common in my experience and this change would require less default edits when adding a lot of activities to a task.

See Screenshot:
Error Updating.

Trust [Wayfarers Haven] — Today at 10:17 AM
Because Spire hasn't been updated for EQEmu/Server#2317 I assume

When using the description editor component and editing activity level descriptions, provide the default activity description to the user for reference.

Method arguments do not show up in search today

When editing spells and selecting the resist type, the list does not give a selection for slot 9, corruption.
If you get time, not a huge issue.
Thanks :)

Need to change Task activities with an Activity Type of 6 (Tradeskill) to use the Item List value in the activity description instead of the Activity Target value (current functionality).

When a user navigates to EVENT documentation; have a link on the event to examples as well as show examples when first navigating to the event.

This bug has bigger implications. A server will stop functioning correctly if the task isn't saved to the DB correctly.

To reproduce:
a. Open Spire
b. Go to Tasks and Create a New task
c. Set your description and rewards.
d. Hit Save
e. Go to the Activities Tab
f. Create your first activity. You can hit save After.
g. Use the + to create another activity. Enter in your details and hit Save.
f. Now that the task has been saved look at the tasks list and select another task.
g. Toggle back to the task you just created. The 2nd activity you just created will revert itself to Kill 1 Orc task.
h. At this point We've noticed on Karana that the task is corrupted. The server (see screenshot)

Begins to toggle between 28 and 32,, and you loose connection with the world server. Eventually Clients cease to be able to zone into new zones with a "failed to zone XXXX" message.
I. ... To resolve the server from completely nuking itself, i opened spire again and deleted the newly created task.. After that the server held a 30/30 zone stable and once i rebooted the server we're back in biz.

-Thanks
-ish (mort)

=======Old info Below but might be useful=========
I think there is a bug in Tasks. Essentially making a 2nd activity entry.
Steps: I cloned a task
Click the + Activities to add another Step 1,
Change goal method to kill a few npcs (list) within the Tab I hit save.
Task flashes that it is saved and updated.
However, if you go to another task and go back to the one you just saved the newly added 2nd activity isn't saved.

If a Spell ID is used in Bot or npc_spells_entries, and that Spell ID doesn't exist under Spells_new, then Spells in NPC/Bot Spells will fail to load (however the count will show accurately)

subject says it all.

[Update] Checking for updates...
[Update] Running as binary [spire-windows-amd64.exe]
[Update] Spire is already up to date @ [v1.13.3]

/ // / ___
/ // / _ / _
//_////___/ v4.7.2
High performance, minimalist Go web framework
https://echo.labstack.com
_____________________________O/
O
⇨ http server started on [::]:8090
method=GET, uri=/, status=200, time=108.5877ms
method=GET, uri=/api/v1/app/env, status=200, time=87.0037ms
method=GET, uri=/api/v1/me, status=200, time=595.7µs
method=GET, uri=/api/v1/me, status=200, time=0s
{"time":"2022-08-12T16:46:21.6622244-07:00","level":"-","prefix":"echo","file":"recover.go","line":"113","message":"[PANIC RECOVER] runtime error: invalid memory address or nil pointer dereference goroutine 31 [running]:\ngithub.com/labstack/echo/v4/middleware.RecoverWithConfig.func1.1.1()\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/middleware/recover.go:93 +0x14e\npanic({0xfa7720, 0x2b970b30})\n\t/usr/local/go/src/runtime/panic.go:1038 +0x215\ngorm.io/gorm.(*DB).getInstance(0x48e637)\n\t/home/go/pkg/mod/gorm.io/[email protected]/gorm.go:363 +0x18\ngorm.io/gorm.(*DB).Model(...)\n\t/home/go/pkg/mod/gorm.io/[email protected]/chainable_api.go:18\ngithub.com/Akkadius/spire/internal/http/controllers.(*ConnectionsController).list(0xc00021a1b0, {0x2a72ac50, 0xc000156500})\n\t/drone/src/internal/http/controllers/connections_controller.go:141 +0xba\ngithub.com/Akkadius/spire/internal/http/middleware.RateLimiterWithConfig.func1.1({0x2a72ac50, 0xc000156500})\n\t/drone/src/internal/http/middleware/ratelimiter.go:173 +0x86f\ngithub.com/Akkadius/spire/internal/http/middleware.ReadOnlyMiddleware.Handle.func1.1({0x2a72ac50, 0xc000156500})\n\t/drone/src/internal/http/middleware/read_only_middleware.go:33 +0x871\ngithub.com/labstack/echo/v4/middleware.JWTWithConfig.func1.1({0x2a72ac50, 0xc000156500})\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/middleware/jwt.go:206 +0xbe\ngithub.com/labstack/echo/v4/middleware.JWTWithConfig.func1.1({0x2a72ac50, 0xc000156500})\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/middleware/jwt.go:206 +0xbe\ngithub.com/labstack/echo/v4.(*Echo).add.func1({0x2a72ac50, 0xc000156500})\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/echo.go:520 +0x51\ngithub.com/Akkadius/spire/internal/http/spa.PackedSpaService.MiddlewareHandler.func1.1({0x2a72ac50, 0xc000156500})\n\t/drone/src/internal/http/spa/spa.go:84 +0x5a5\ngithub.com/labstack/echo/v4/middleware.CORSWithConfig.func1.1({0x2a72ac50, 0xc000156500})\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/middleware/cors.go:142 +0x470\ngithub.com/labstack/echo/v4/middleware.RecoverWithConfig.func1.1({0x2a72ac50, 0xc000156500})\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/middleware/recover.go:119 +0x10a\ngithub.com/labstack/echo/v4/middleware.LoggerWithConfig.func2.1({0x2a72ac50, 0xc000156500})\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/middleware/logger.go:117 +0xe2\ngithub.com/Akkadius/spire/internal/http/middleware.RequestLogMiddleware.Handle.func1.1({0x2a72ac50, 0xc000156500})\n\t/drone/src/internal/http/middleware/request_log_middleware.go:30 +0xb4\ngithub.com/labstack/echo/v4.(*Echo).ServeHTTP.func1({0x2a72ac50, 0xc000156500})\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/echo.go:624 +0x132\ngithub.com/labstack/echo/v4/middleware.RemoveTrailingSlashWithConfig.func1.1({0x2a72ac50, 0xc000156500})\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/middleware/slash.go:118 +0x211\ngithub.com/labstack/echo/v4.(*Echo).ServeHTTP(0xc01045a000, {0x2a6f9d58, 0xc00fb020e0}, 0xc00ffae800)\n\t/home/go/pkg/mod/github.com/labstack/echo/[email protected]/echo.go:630 +0x3bc\nnet/http.serverHandler.ServeHTTP({0xc010a74ff0}, {0x2a6f9d58, 0xc00fb020e0}, 0xc00ffae800)\n\t/usr/local/go/src/net/http/server.go:2878 +0x43b\nnet/http.(*conn).serve(0xc0000e4500, {0x2a7073a0, 0xc010a74f00})\n\t/usr/local/go/src/net/http/server.go:1929 +0xb08\ncreated by net/http.(*Server).Serve\n\t/usr/local/go/src/net/http/server.go:3033 +0x4e8\n\ngoroutine 1 [chan receive]:\ngithub.com/Akkadius/spire/internal/desktop.(*WebBoot).Boot(0xc00ffa1460)\n\t/drone/src/internal/desktop/web_boot_service.go:57 +0x1c9\nmain.main()\n\t/drone/src/main.go:36 +0x185\n\ngoroutine 15 [IO wait]:\ninternal/poll.runtime_pollWait(0x21c7d7cf5b0, 0x72)\n\t/usr/local/go/src/runtime/netpoll.go:234 +0x89\ninternal/poll.(*pollDesc).wait(0xc00ffa3f40, 0x2ad02830, 0x0)\n\t/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0x32\ninternal/poll.execIO(0xc00017db98, 0x2a5d6070)\n\t/usr/local/go/src/internal/poll/fd_windows.go:175 +0xe5\ninternal/poll.(*FD).Read(0xc00017db80, {0xc00021a9d1, 0x1, 0x1})\n\t/usr/local/go/src/internal/poll/fd_windows.go:441 +0x25f\nnet.(*netFD).Read(0xc00017db80, {0xc00021a9d1, 0xc00ffa3f70, 0x2b9f9201})\n\t/usr/local/go/src/net/fd_posix.go:56 +0x29\nnet.(*conn).Read(0xc0000ce708, {0xc00021a9d1, 0x0, 0x1})\n\t/usr/local/go/src/net/net.\n"}
method=GET, uri=/api/v1/connections, status=422, time=42.9148ms
method=GET, uri=/api/v1/me, status=200, time=0s
method=GET, uri=/api/v1/me, status=200, time=0s
method=GET, uri=/eq-asset-preview-master/assets/wallpaper/spire-wall.jpg, status=200, time=275.4721ms
method=GET, uri=/api/v1/app/changelog, status=200, time=9.0184ms

Upper case characters in this method (As shown on spire) cause it to not be recognized: http://spire.akkadius.com/quest-api-explorer?lang=perl&q=updatespawn&h=UpdateSpawnTimer

Lua event example is wrong; has perl style brackets

function event_drop_item(e)
	-- Item-event_drop_item
	-- Exported event variables
}

nothing in the txt file... spells_us.txt works fine

Could be handy :)

In item editor when you set a click effect on an item. We have it as the recast time is displayed in milliseconds. It should be set in seconds. Recast of 10 seconds = value of 10.

Requesting feature to translate the task activity ID withing the description selector so you don't have to add 1 to the desired activity id when creating sub-descriptions.

See subject. This is on hosted spire. You can however change it to a non-zero value.

I have not been able to figure out the causal factor yet, but some work, some don't.

Tested and still present for me using hosted spire.

Scenario:

You are editing tasks.
You click into "Goal ID"-> The NPC Selector opens.
You start to move the mouse over to the NPC selector to make a selection, etc...BUT...there are several textboxes in between the Goal ID text box and the right side of the screen.
If you mouse-over one of the other text boxes, the npc selector goes poof and you have to start over.

Is there a way to add a hover delay of some sort before anything changes with the selector component?

I love that you can filter race models by zone in the race viewer, would also be cool if you could also 1) See what zones a specific model is present within (reverse of current functionality) and 2) have some integrated data from: http://www.shendare.com/EQ/Emu/EQRI/RoF2_EQRaces.htm

You can however manually type in the npc type id

When you open up the item and npc selector and send focus to the search box, auto-highlighting the default text would allow you to immediately start typing, as apposed to having to delete the default value first.

For quite a few releases now, all items show Combat Effects, including those with a value of 0.

When you clone an entire task, the resulting new cloned task only has the first task activity copied over from the origional task.

Reward Item does not appear to show in the in-game Task UI (see image below):

The item did not get awarded to the player on completion, either. The item exists (I summoned it to be sure).

The goal count should be included in the activity description for activities with an activity type of "Deliver".

If the Goal ID is 1 (default), have the item selector default to the search window, as apposed to the "No items were found" window, requiring you to click the "Return to Search" button before you can start searching.

Items:

• Add New Button
• Delete Button

NPC Spells:

• Add Button.
• A Back button (back to main list) when you've already edited a spell.
• Bulk Edit. Instead of editing each min/max level the main grid to adjust recast times, levels etc might be cool
• Bot spell editing ability. This isn't in scope but would be great I think

NPC Edits:

• Pet update section. Add new etc.

Zones:

• Bulk Edit > Scale all NPC's in Zone.

Goes without saying but I'll say it anyway. Spire is simply amazing.

Error binding to entity [code=400, message=Unmarshal type error: expected=uint, got=string, field=task_activities.goalid, offset=623, internal=json: cannot unmarshal string into Go struct field TaskActivity.task_activities.goalid of type uint]

:)

Methods with a luabind::object return type do not show in Lua methods.

Both Bucket_Name and Bucket_Value are strings values which should be able to accept a number value.

It's pretty common to use a number in the Table data_buckets.Value" Field, which is a text field, which bot_spells_entries.Bucket_Value uses to determine if a bot can use a spell. same with Bucket_name (but less likely to just be a number)

Task Step as shown in the activities list and the Task Step textbox can get out of sync when deleting tasks and/or reordering tasks.

I will try to narrow this down more as I get time today.

Sometimes when you delete an activity from a task, the activity fields below the activity do not appear for the last activity in the list.

Issue is not resolved by refreshing the browser.

Was testing today.. Started adding multiple activities.... i added 3 and populated them.. Then hit the + button, and it wiped out the 2 except for the first one with the default kill activity.

Details of SPA: EQEmu/Server#1477

Trying to install Spire on Debian, following the github steps and eventually get the following error every time:

cp: cannot overwrite non-directory './frontend/public/eq-asset-preview-master' with directory '/tmp/assets/eq-asset-preview-master/'
make[1]: *** [Makefile:186: install-assets] Error 1
make: *** [Makefile:178: install] Error 2

I've removed everything and restarted the install, but keep getting stuck at the same point.

Source call is different from the others

	for (auto iter = events.begin(); iter != events.end(); ++iter) {
		quest_proximity_event& evt = (*iter);
		if (evt.npc) {
			std::vector<EQ::Any> args;
			parse->EventNPC(evt.event_id, evt.npc, evt.client, "", 0, &args);
		} else {
			std::vector<EQ::Any> args;
			args.push_back(&evt.area_id);
			args.push_back(&evt.area_type);
			parse->EventPlayer(evt.event_id, evt.client, "", 0, &args);
		}
	}