Git Product home page Git Product logo

zip-visit's People

Contributors

akhudek avatar ddellacosta avatar edwardbetts avatar gtrak avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar

Forkers

quizdr luxbock the-real-neil postspectacular plumpmath edwardbetts nrfm orenra refset gtrak

zip-visit's Issues

Update fast-zip-visitor?

Dear maintainer,

When running the PuppetDB testsuite in Debian with fast-zip 0.7.0 and the current version of fast-zip-visitor, many errors like this one are generated:

ERROR in (query-with-explain) (core.cljc:117)
Uncaught exception, not in assertion.
expected: nil
  actual: java.lang.ClassCastException: class clojure.lang.PersistentVector cannot be cast to class clojure.lang.ISeq (clojure.lang.PersistentVector and clojure.lang.ISeq are in unnamed module of loader 'app')
 at fast_zip.core$down.invokeStatic (core.cljc:117)
    fast_zip.core$down.invoke (core.cljc:108)
    fast_zip.visit$visit.invokeStatic (visit.clj:47)
    fast_zip.visit$visit.invoke (visit.clj:32)
    puppetlabs.puppetdb.zip$pre_order_visit.invokeStatic (zip.clj:112)
    puppetlabs.puppetdb.zip$pre_order_visit.invoke (zip.clj:107)

If we downgrade to fast-zip 0.5.0, those errors don't appear.

Would it be possible to update fast-zip-visitor so that it works with the latest and greatest fast-zip?

Thanks!

Include loc in `(v dir node state)`?

As per the title, would you accept a PR to modify visit-node so that loc is passed to the visitors i.e. (v dir loc node state)?

On another note, (z/node loc) is immediately repeated on line 22.

Great library 👍

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.