Is there any particular reason why Epoxy supports SDK from API 16?
A lot of projects still have minSdkVersion set to 15, same for default project created in Android Studio.

I'm referring to https://developer.android.com/reference/android/support/v7/widget/RecyclerView.ViewHolder.html#getAdapterPosition().

In particular, the readme suggests we should save click listeners as fields to reuse with each model. How do you get a reference to the model from a re-usable click listener?

How do I know where I click on Model in recycleView

To make chaining easier.

@gpeal

The layout I want to make is this:
-Header
-LinearLayoutManager(Horizontal)
-Header
-LinearLayoutManager(Vertical)

The layout should be managed by single RecyclerView.

I'm thinking this could be useful for debugging, at times where a model is logged and its toString implementation gives details about it. If we generate an implementation that lists all the attributes it could make logs more useful.

Low priority.

As per RecyclerView Animations and Behind the Scenes (Android Dev Summit 2015)
https://youtu.be/imsr8NrIAMs?t=36m2s you should check the ViewHolder's position before triggering an onItemClick that was pass in Model and how to properly handle item click is this correct way ??

public class ButtonModel extends EpoxyModelWithHolder<ButtonModel.ButtonHolder> {

@EpoxyAttribute
String text;
@EpoxyAttribute(hash = false)
ItemClickListener itemClickListener;



@Override
protected int getDefaultLayout() {
    return R.layout.model_button;
}


@Override
public void bind(final ButtonHolder holder) {
    super.bind(holder);

    holder.container.setBackgroundResource(R.color.pink_200);
    holder.container.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            itemClickListener.itemClick(holder.container, text);
        }
    });
    holder.text.setText(text);


}


@Override
public int getSpanSize(int totalSpanCount, int position, int itemCount) {
    return 1;
}

@Override
protected ButtonHolder createNewHolder() {
    return new ButtonHolder();
}


static class ButtonHolder extends BaseEpoxyHolder {

    @BindView(R.id.text)
    TextView text;
    @BindView(R.id.container)
    FrameLayout container;
}

  public interface ItemClickListener {
      void itemClick(View parent, String text);
   }
  }

I try to apply EpoxyAttribute to field in Kotlin, like below:

@EpoxyModelClass(layout = R.layout.model_epoxy)
abstract class TestEpoxyModel(@EpoxyAttribute @ColorInt var color: Int) : EpoxyModel<View>() {
	override fun bind(view: View?) {
		view?.setBackgroundColor(color)
	}
}

And got error on compile annotation, like below:

com.airbnb.epoxy.EpoxyProcessorException: EpoxyAttribute annotations must not be on private or static fields. (class: TestEpoxyModel, field: color)
e: Some error(s) occurred while processing annotations. Please see the error messages above.

Once you scroll past the hidden models you can't scroll back up. Hidden models have a span size of 0, which normally seems to work fine, but I found that for a total span count of 2, where two consecutive models are hidden, the recyclerview just breaks and won't scroll up past the hidden models.

Hey! I was really interested in a way that you guys used for testing annotation processor. I tried to run tests on my local machine and all tests failed because of java.lang.IllegalArgumentException: resource BasicModelWithAttribute.java not found. and etc. Am I missing something?

I have root RecyclerView that's used with Epoxy, then in one of my Epoxy models I have another RecyclerView (also vertical) where I use a normal RecyclerView.Adapter. Whenever the page loads, the root RecyclerView with the Epoxy adapter scrolls down until the nested RecyclerView is visible.

When I switch nested RecyclerView to having a horizontal LinearLayoutManager, this issue doesn't happen. Have you seen this issue before? When I've tried using them in the past, I've usually had scrolling/sizing issues but those seem to work fine when using Epoxy, the only part that seems to have an issue is that it automatically scrolls into view.

I'll share some more details in case you might be able to suggest an alternative implementation. I'm building something similar to this:

I have the root RecyclerView which adds multiple SettingsContainer epoxy models. SettingsContainer has a title TextView and a RecyclerView that contains the settings items inside it.

I observed that unbind is not always called before a view is rebound to another model (recycled). I assume this is working as intended and not a bug. However I think the documentation on this behavior could be improved.

Knowing the described behavior I can interpret this information into the documentation:

However without this knowledge this was absolutely not obvious for me from the documentation. Especially because of the naming of the two methods bind/unbind and the observed behavior in most cases (most of the time unbind is called before the view is rebound).

a method like model.reset() could set all annotated fields back to their defaults. This is useful if a model is reused or changed and you don't want any previously set values carrying over to the new usage.

is there any sample that implemented load more when reaching at the end of recyclerView?

From my developer experience, this project is tremendous and it resolved alot of problems from memory to module hierarchy issues. As title, are there any chances or thoughts to advance this module or project into a React-native project?

This can help prevent a tricky bug where a model id is changed without an accompanying notify call.

Additionally, this would allow us to optimize the diff algorithm since we can check models list size for changes to know if there were removals or additions.

The downside is it would prevent reusing models in something like a model pool for memory optimization. We don't currently do that anywhere, and models are generally fairly small so unless somebody had thousands of them and recreated them often that shouldn't be a big issue.

The pros seem to outweigh the cons.

Thoughts @gpeal ?

No option to use programmatically generated views to be used with the EpoxyAdapter

In the annotation processor we look for annotated fields on super classes and bundle them with sub classes. This relies on the super classes being included in the processor - we don't walk up the inheritance tree and explicitly look for super classes with annotations.

This creates a problem where if the super class is in a different module it's annotated fields will not be included in generated subclasses in other modules.

Solution should be to walk up the inheritance tree for each model class found in the processor.

I was trying out auto diffing with realm objects , but can't seem to get it working .
I used the @EpoxyAttribute annotation to autogenerate hashcodes and helpers.
But after some time debugging it seems that since realm returns different objects but equivalent objects , i got different hashcodes .

I can't override hashcode in my main model , because the generated model still generates hash codes differently from my implentation.

use a faster implementation

So that models can return different layouts based on column count or grid mode.

This is a preliminary idea, I need to think it through more

cc @gpeal

We can generate the parcelable code on models so that they can easily be saved.

If we go this route we may also want to add an easy way for the models list on EpoxyAdapter to be included in saved state.

It would default to true, but you could change it to false if you don't want to expose the setter.

Something like @EpoxyAttribute(setter=false) int value

The use case is when you want to the change the value internally in the model but don't want external usage to change it.

Just an idea I'm playing around with, needs more thought

public class HeaderModel extends EpoxyModel
{
@EpoxyAttribute String title;
@EpoxyAttribute String subtitle;
@EpoxyAttribute String description;
@EpoxyAttribute(hash=false) View.OnClickListener clickListener;

@LayoutRes
public int getDefaultLayout() {
return R.layout.view_model_header;
}

@OverRide
public void bind(HeaderView view) {
view.setTitle(title);
view.setSubtitle(subtitle);
view.setDescription(description);
view.setOnClickListener(clickListener);
}

}

Having added this property @EpoxyAttribute(hash=false) View.OnClickListener clickListener; it still added in hashCode of generated class

Subclasses are not being generated for EpoxyModelClass (picture included below). The EpoxyModelClass is also missing the layout property to be overwritten within our models (@EpoxyModelClass(layout = R.layout.model_button) gives "cannot resolve method layout" error). This is our EpoxyModelClass.java:

And this is yours:

Generated subclasses are not recognized in SampleAdapter.java.

I want to update models by model id as addModels() will throw "java.lang.IllegalStateException: Two models have the same ID. ID's must be unique! ", can we have this method in EpoxyAdapter?

protected int getModelPositionByStableId(long id) {
    int size = models.size();
    for (int i = 0; i < size; i++) {
        if (models.get(i).id() == id) {
            return i;
        }
    }

    return -1;
}

Can either not include those in the generated class or throw an error at generation time

If there is a method on a model that takes varargs as an argument (EpoxyModel<?> myMethod(Long... numbers)) and the processor duplicates the method on a generated subclass the generated method will have an array in the parameters instead of varargs (EpoxyModel<?> myMethod(Long[] numbers))

In Epoxy Processor
builder.beginControlFlow("if ($L != null && that.$L == null" + " || $L == null && that.$L != null)",
No Operator Precedence exists
Reference

Currently EpoxyAdapter holds strong reference to views. Does this means that Adapter can't be field in Fragment and should be null'ed on onViewDestroyed? Ref is hold to Views by boundViewHolders

e.g.

Fragment1 {
  val adapter: EpoxyAdapter 

  @override fun onCreateView(...) {
    <..recycler setup..>
  }
}

And I go to next Fragment, then View of Fragment1 is leaked until whole fragment is Destroyed.

These versions were (mistakenly) removed in support repository rev 38.

I guess the deps should be 24.2.1 instead?

as a workaround one can depend on 24.2.1 explicitly.

So that we can delegate view clean up to a model instead of handling it in the adapter

I use swipeRefreshLayout to update recyclerview for latest changes. However I could't understand how notifyModelsChanged() method works. When the app is loaded, I fetch items from our Realm database then insert them into recyclerview, but when user triggers swipeRefresh I fetch items from server, add new items with models.add() and run notifyModelsChanged(). However, it adds all newcoming items at the end of the list instead of dispatching changes. (My local and remote items are have same id).

public void addPosts(List<PostRealm> posts) {
    for (PostRealm post : posts) {
      final int postType = post.getType();

      if (postType == 0) {
        models.add(createNormalQuestion(post));
      } else if (postType == 1) {
        models.add(createRichQuestion(post));
      } else if (postType == 2) {
        models.add(createBlog(post));
      }
    }

    notifyModelsChanged();
}

public class NormalQuestionModel extends EpoxyModelWithHolder<NormalQuestionModel.QuestionHolder> {

  @EpoxyAttribute PostRealm post;
  @EpoxyAttribute(hash = false) OnProfileClickListener onProfileClickListener;
  @EpoxyAttribute(hash = false) OnShareClickListener onShareClickListener;
  @EpoxyAttribute(hash = false) OnCommentClickListener onCommentClickListener;
  @EpoxyAttribute(hash = false) OnReadMoreClickListener onReadMoreClickListener;
  @EpoxyAttribute(hash = false) OnPostOptionsClickListener onPostOptionsClickListener;
  @EpoxyAttribute(hash = false) OnVoteClickListener onVoteClickListener;

  @Override protected QuestionHolder createNewHolder() {
    return new QuestionHolder();
  }

  @Override protected int getDefaultLayout() {
    return getLayout();
  }

  @Override public void bind(QuestionHolder holder, List<Object> payloads) {
    if (!payloads.isEmpty()) {
      if (payloads.get(0) instanceof PostRealm) {
        PostRealm post = (PostRealm) payloads.get(0);
        holder.voteView.setVotes(post.getVotes());
        holder.voteView.setCurrentStatus(post.getDir());

        long comments = this.post.getComments();
        comments += 1;
        holder.tvComment.setText(CountUtil.format(comments));

        if (!TextUtils.isEmpty(post.getAcceptedCommentId())) {
          this.post.setAcceptedCommentId(post.getAcceptedCommentId());
        }
      }
    } else {
      super.bind(holder, payloads);
    }
  }

  @Override public void bind(QuestionHolder holder) {
    holder.bindDataWithViewHolder(post, isNormal());
    setupClickListeners(holder);
  }

  @Override public void unbind(QuestionHolder holder) {
    clearClickListeners(holder);
  }

  @Override public boolean shouldSaveViewState() {
    return true;
  }

  private void setupClickListeners(QuestionHolder holder) {
    holder.ivUserAvatar.setOnClickListener(
        v -> onProfileClickListener.onProfileClick(v, post.getOwnerId()));

    holder.tvUsername.setOnClickListener(
        v -> onProfileClickListener.onProfileClick(v, post.getOwnerId()));

    if (onReadMoreClickListener != null && post.hasReadMore()) {
      holder.tvContent.setOnClickListener(
          v -> onReadMoreClickListener.onReadMoreClickListener(v, post));
    }

    holder.tvShare.setOnClickListener(v -> onShareClickListener.onShareClick(v, post));

    holder.tvComment.setOnClickListener(
        v -> onCommentClickListener.onCommentClick(v, post.getId(), post.getOwnerId(),
            post.getAcceptedCommentId(), PostType.TYPE_NORMAL));

    holder.ibOptions.setOnClickListener(
        v -> onPostOptionsClickListener.onPostOptionsClick(v, this, post.getId(),
            post.getOwnerId()));

    holder.voteView.setOnVoteEventListener(direction -> {
      post.setDir(direction);
      onVoteClickListener.onVoteClick(post.getId(), direction, OnVoteClickListener.Type.POST);
    });
  }

  private void clearClickListeners(QuestionHolder holder) {
    holder.ivUserAvatar.setOnClickListener(null);
    holder.tvUsername.setOnClickListener(null);
    holder.tvContent.setOnClickListener(null);
    holder.tvShare.setOnClickListener(null);
    holder.tvComment.setOnClickListener(null);
    holder.ibOptions.setOnClickListener(null);
    holder.voteView.setOnVoteEventListener(null);
  }

  private boolean isNormal() {
    return getLayout() == R.layout.item_feed_question_normal;
  }

  public String getItemId() {
    return post.getId();
  }

  static class QuestionHolder extends BaseEpoxyHolder {
    @BindView(R.id.iv_item_feed_user_avatar) ImageView ivUserAvatar;
    @BindView(R.id.tv_item_feed_username) TextView tvUsername;
    @BindView(R.id.tv_item_feed_time) TimeTextView tvTime;
    @BindView(R.id.tv_item_feed_bounty) TextView tvBounty;
    @BindView(R.id.ib_item_feed_options) ImageButton ibOptions;
    @BindView(R.id.tv_item_question_normal_content) TextView tvContent;
    @BindView(R.id.tv_item_feed_share) CompatTextView tvShare;
    @BindView(R.id.tv_item_feed_comment) CompatTextView tvComment;
    @BindView(R.id.tv_item_feed_vote) VoteView voteView;
    @Nullable @BindView(R.id.view_item_question_normal_category) TagView tagView;

    void bindDataWithViewHolder(PostRealm post, boolean isNormal) {
      final Context context = ivUserAvatar.getContext().getApplicationContext();

      Glide.with(context)
          .load(post.getAvatarUrl())
          .bitmapTransform(CropCircleTransformation.getInstance(context))
          .into(ivUserAvatar);

      tvUsername.setText(post.getUsername());
      tvTime.setTimeStamp(post.getCreated().getTime() / 1000);
      tvBounty.setVisibility(post.getBounty() == 0 ? View.GONE : View.VISIBLE);
      tvBounty.setText(String.valueOf(post.getBounty()));
      tvContent.setText(isNormal
          ? ReadMoreUtil.readMoreContent(post.getContent(), 200)
          : post.getContent());
      tvComment.setText(CountUtil.format(post.getComments()));
      voteView.setVotes(post.getVotes());
      voteView.setCurrentStatus(post.getDir());

      if (tagView != null) {
        tagView.setData(post.getCategoryNames());
      }

      tintDrawables();
    }

    private void tintDrawables() {
      DrawableHelper.withContext(tvShare.getContext())
          .withDrawable(tvShare.getCompoundDrawables()[0])
          .withColor(android.R.color.secondary_text_dark)
          .tint();

      DrawableHelper.withContext(tvComment.getContext())
          .withDrawable(tvComment.getCompoundDrawables()[0])
          .withColor(android.R.color.secondary_text_dark)
          .tint();
    }
  }
}

Can you please provide a sample for working with carousels? For example, a horizontal RecyclerView inside the vertical RecyclerView. The issue I'm facing is when data is binded to the horizontal view it becomes a bit sluggish on binding.

Thank you

�Cannot be Use android.support.v4.widget.SwipeRefreshLayout, Loading Progressbar not show
p.
I'm if replace RecyclerView and RecyclerView.Adapter model,When Drop Down Can mormally Display
please my Help

Since it's useful in some cases

I use Epoxy to manage RecycleView inside SwipeRefreshLayout, like below:

 <android.support.v4.widget.SwipeRefreshLayout
      android:id="@+id/srLayout"
      android:layout_width="match_parent"
      android:layout_height="match_parent">

      <android.support.v7.widget.RecyclerView
          android:id="@+id/rvList"
          android:layout_width="match_parent"
          android:layout_height="match_parent"/>
  </android.support.v4.widget.SwipeRefreshLayout>

It is weird when I hide first model of RecycleView by EpoxyModel.hide(), SwipeRefreshLayout doesn't work anymore.
I create a TestProject, https://github.com/fanxu123/EpoxyTest, specially for demonstration.
Please help, thanks.

hello, my use Dagger2 and Epoxy. canot not use to Make Class file?
Please Need help?

I like how butterknife does it https://github.com/JakeWharton/butterknife/blob/master/build.gradle

Ideally you can arbitrarily arrange views/models into whatever grouping pattern you want.

I have something working that does this, but would need to spend some time making it more robust before adding it here.

If there is demand for it I can prioritize it.

Helpful for models that extend other models with Epoxy attributes, where the subclass doesn't need to add any attributes

When using hash=false as an attribute param we don't include that field in the model hashcode at all. We can change this to instead include it in the hashcode as a boolean, for whether it is null or not (would not work with primitives).

The idea is that you may not care about the hash (eg anonymous click listeners that all do the same thing), but there should be a difference between having that field be set and having it be null

I guess for primitives we would leave it as is and exclude them, but it doesn't make sense to not hash primitives (that I can think of).

I have problems using epoxy, when I've already added my model in EpoxyAdapter and already set it to the RecyclerView. Somehow when I'm using recyclerView.getLayoutManager().findViewByPosition(0), it always return null. I need to get View from the model that I've already added. Please help me, thank you !

One of the most common problems I see is either not implementing hashcode on an @EopxyAttribute object, or not using hash=false if that object should not have hashcode (like click listeners).

A lint rule could help a ton with this.

Would love any help if someone wants to set this up.