aiidateam / aiida-export-migration-tests Goto Github PK

Is this really necessary anymore?

The reasoning for this repo states:

In order to not take up unneccesary disk space, when installing AiiDA

But the tests are no longer internal to the aiida-core package

The reason is that currently if I need to skip certain tests, because temporarily the export archives are invalid, can only be done by commenting the lines in the test list. Since I do not have access to the functions, I cannot use unittest.skip or something like that. This is dangerous because this way we do not get a message of skipped tests.

Having the test functions themselves in aiida-core is also not a big burden, it is mostly the archives and the code to generate them that is useful to have in this external package.

The AiiDA export archive version is updating to v0.9 - this should be updated accordingly.

See also aiidateam/aiida-core#3912.

For instance there is a comment (probably non-critical) on custom_environment_variables for CalcJobs. Should we try to generate CalcJobs with all these attributes that change? (Similarly for other things that have changed).

As proposed here by @sphuber, it may be helpful to update the release notes according to the actual AiiDA version, in which the specific export archive adheres to.

Furthermore, for the future, a new update should say unreleased (or similar) in stead of the latest released AiIDA version.

All that is left is to release this on PyPi.

However, first we should make sure the name is what we want for this repo, and that the way I have versioned it is okay.