ai2cm / fv3core Goto Github PK

Dependabot couldn't resolve your project's dependencies as it couldn't access daint_venv.

You can grant Dependabot access to daint_venv by adding the repository here. We'll automatically close this issue and kick off another update run once permission is granted.

View the update logs.

After pip installing fv3core, I get this error when trying to run the tests. Did yaml get added recently and someone forgot to add pyyaml to requirements.txt?

ImportError while loading conftest '/home/jdahm/fv3core/tests/conftest.py'.
tests/conftest.py:8: in <module>
    import translate
tests/translate/__init__.py:1: in <module>
    from . import translate
tests/translate/translate.py:6: in <module>
    import fv3core._config
fv3core/__init__.py:1: in <module>
    from .decorators import disable_stencil_report, enable_stencil_report
fv3core/decorators.py:12: in <module>
    import yaml
E   ModuleNotFoundError: No module named 'yaml'

Should we make this change to be consistent with the new naming scheme? It would involve some changes to the testing infrastructure, and all users with a clone would have to run a command to update the tracking branch.

Dependabot couldn't resolve your project's dependencies as it couldn't access daint_venv.

You can grant Dependabot access to daint_venv by adding the repository here. We'll automatically close this issue and kick off another update run once permission is granted.

View the update logs.

Currently only one instance of the fv3ser image can be run at a time, because of a name conflict when re-initializing the data container. Perhaps if we only initialize if it's not already running it will fix it?

docker: Error response from daemon: Conflict. The container name "/TestDataContainer-0.1.1" is already in use by container "e8163d6c7647e6e7b5795defaacf2d64f7764a76eaef8fcad1b9025aeae811b0". You have to remove (or rename) that container to be able to reuse that name.
See 'docker run --help'.
make[1]: *** [data_container] Error 125
make: *** [tests] Error 2```

This normally wouldn't be an issue, but sometimes containers keep running when you don't expect them to. Like, right now as far as I know I have none running.

Dependabot couldn't resolve your project's dependencies as it couldn't access daint_venv.

You can grant Dependabot access to daint_venv by adding the repository here. We'll automatically close this issue and kick off another update run once permission is granted.

View the update logs.

Currently there is a FORTRAN_VERSION in the Makefile that is used as part of the tags for the compiled fortran model image with serialization on and for image containing the output serialized data it produces. But nothing is enforcing this version be tied to a particular submodule fortran code hash... Mimic the setup in fv3gfs-python
https://github.com/VulcanClimateModeling/fv3gfs-python/blob/master/.circleci/config.yml
in particule, the CIRCLE_TAG section, so that when a particular commit is tagged, circleCI should run make generate_test_data and push the corresponding compiled model and data images.

Here is some python code for the fv_subgridz idea:

import numpy as np

nk = 6

shape = (nk, )

mc = np.ones(shape)
ri = np.ones(shape)
delp = np.ones(shape)
q = [1., 2., 3., 2., 1., 0.]

ri_ref = 2

ri[1] = ri_ref
ri[-1] = ri_ref

print(q)
for k in range(1, nk):
    if ri[k] < ri_ref:
        h0 = mc[k] * (q[k] - q[k-1])
        q[k-1] += h0 / delp[k-1]
        q[k]   -= h0 / delp[k]
print(q)

anbd here is how a stencil might compute that:

with interval(1, None):
    k_ind = index(K)
    with interval(k_ind, None):
        k_inner = index(K)
        h0 = mc[0, 0, 0] * (q[0, 0, 0] - q[0, 0, -1])
        if mod(k_inner, 2):
            q += h0 / delp[0, 0, 0]
        else:
            q -= h0 / delp[0, 0, 0]

gtstencil seems like it is no longer used.

Dependabot couldn't resolve your project's dependencies as it couldn't access daint_venv.

You can grant Dependabot access to daint_venv by adding the repository here. We'll automatically close this issue and kick off another update run once permission is granted.

View the update logs.

Dependabot couldn't resolve your project's dependencies as it couldn't access daint_venv.

You can grant Dependabot access to daint_venv by adding the repository here. We'll automatically close this issue and kick off another update run once permission is granted.

View the update logs.

When trying to run make test with fv3core @ 6dd4665, it seems that this refers to a non-publicly-available submodule:

(venv) avj@platypus ~/clones/fv3core/master$ git submodule init && git submodule update
Cloning into '/home/avj/clones/fv3core/master/external/daint_venv'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of '[email protected]:VulcanClimateModeling/daint_venv.git' into submodule path '/home/avj/clones/fv3core/master/external/daint_venv' failed
Failed to clone 'external/daint_venv'. Retry scheduled
Cloning into '/home/avj/clones/fv3core/master/external/daint_venv'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of '[email protected]:VulcanClimateModeling/daint_venv.git' into submodule path '/home/avj/clones/fv3core/master/external/daint_venv' failed
Failed to clone 'external/daint_venv' a second time, aborting

Indeed, the repository https://github.com/VulcanClimateModeling/daint_venv either doesn't exist (or is private).