ahoischen / capture Goto Github PK

Currently, Title, ProductCode, and UniqueID are just defaults. They should be changed before capture is released to avoid overwriting other apps using default values.

Create relevant labels for issues and pull requests.

Right now, the default tags are just a constant. Since that is a really inflexible way of handling them, there should be automatic detection of the currently running platform as well as constants to use in SCENARIO's tags.
Automatic tags should include:

• Platform: Citra

• Platform: Hardware

• Platform: 3dsmoo (?)

• Homebrew: true

• Homebrew: false

• Interactive: true

• Interactive: false

Aside from the change to the data model, there should also be a separate menu in the UI for these tags.

By guarding all interactive parts of the code in #ifdefs it should be possible to compile only for automatic tests.

The project will be included via calling a makefile. Parameters such as the include directory and tests may be passed via export in the parent makefile. This interface will be part of the public API and thus has to be defined before the first release.

Automatically test if the program works. Running Catch's self-tests would be great, but the UI tests should suffice.

Currently, include paths such as resources/GFX.h are not specific to capture and might conflict with the main application's headers. This issue should be fixed by moving all capture headers into an include/capture directory. Namespaces and header guards are already set up to not conflict.

Specifying an empty tag string seems to crash.

CreatConfigFromFile is used purely to initialize a CaptureConfig instance and should therefore be moved to capture::config::CaptureConfig::InitFromFile.

The swkbd isn't implemented yet, which means that configuration can't be set in the emulator. This isn't a big issue since emulator builds can just place the config on sdmc and edit that. This isn't something I want to fix either because it would require implementing my own keyboard.

• Add a CONTRIBUTING.md
• Add a CODE_OF_CONDUCT.md

There's currently no way to print only to stdout.

This project now depends on Catch and cpptoml which are MIT licensed. The readme should mention that.

It'd be pretty nice if anybody was actually able to use this. How about I tell them how to?

Give the option to scroll through the output after the test has finished.

CMake doesn't include the romfs for 3dsx targets. It's also way less popular and less maintained.

Citra always launches the interactive menu with both the .3dsx and .cia.

Having a single header library is nice since it makes including so much easier. However writing code in just one header becomes less and less maintainable, so I should switch to multiple files asap.

Force pushes should be forbidden once the project has been released. I see no harm in requiring PR reviews and enforcing these rules for admins too, so I'll do that.

ParseCatchOptions is related to CatchOptions and CatchValueOptions; it shouldn't be included in CaptureConfig. This would also involve moving related constants into the implementation file.

The current images and text on the home menu are just sloppy placeholders and should be changed.