ahmed-abdelrazek / myrssfeeds Goto Github PK

import and export from OPML files

add for LoadDataAsync method in SourcesViewModel class

• IProgress that increment by 1 after adding a source to Sources List.
• Cancel the task before checking if the source works or not.
• Make sure the app compile.

in MyRSSFeeds.Core/Services/SourceDataService.cs at GetSourceInfoFromRssAsync and IsSourceWorkingAsync Methods

https://github.com/ahmedflix25/MyRSSFeeds/blob/e8cc2d3824a79c17d65f76e113f633e7a181b28c/MyRSSFeeds.Core/Services/SourceDataService.cs#L106

https://github.com/ahmedflix25/MyRSSFeeds/blob/e8cc2d3824a79c17d65f76e113f633e7a181b28c/MyRSSFeeds.Core/Services/SourceDataService.cs#L77

Platform version launch
Error Found: The high OS version validation detected the following errors:
Task failed to enable HighVersionLie.
Impact if not fixed: The app should not use version information to provide functionality that is specific to the OS.
How to fix: Please use recommended methods to check for available functionality in the OS. See the link below for more information.
Operating System Version http://go.microsoft.com/fwlink/?LinkId=519280

Add a button that cancel loading data in the Feeds and Sources Views in the appbar at the bottom next to the refresh button

example for cancel button with its icon https://github.com/ahmedflix25/MyRSSFeeds/blob/a80257b81d92680b9dfb3214ee5ca8141d1c6f2b/MyRSSFeeds.UWP/Views/MainPage.xaml#L45-L47
example for the cancel code https://github.com/ahmedflix25/MyRSSFeeds/blob/a80257b81d92680b9dfb3214ee5ca8141d1c6f2b/MyRSSFeeds.UWP/ViewModels/MainViewModel.cs#L398

only enable the cancel button with CanExecute command when IsLoadingData is true

2 pr one for each view

• add cancel loading button for Feeds
• add cancel loading button for Sources

don't forget to raise CanExecute for the cancel command when the data is loading at the beginning of the LoadDataAsync method an example https://github.com/ahmedflix25/MyRSSFeeds/blob/a80257b81d92680b9dfb3214ee5ca8141d1c6f2b/MyRSSFeeds.UWP/ViewModels/MainViewModel.cs#L661

Move the app to WinUI 3 for Webview 2 -offers much better performance- and c# new features
or even Uno Platform with possible Linux version

after selecting a post from the feed the built-in browsers show only the post description when in light mode

https://raw.githubusercontent.com/ahmedflix25/MyRSSFeeds/master/images/Screenshot2020-10-12072300.png
https://raw.githubusercontent.com/ahmedflix25/MyRSSFeeds/master/images/Screenshot2020-10-12072635.png

https://github.com/ahmedflix25/MyRSSFeeds/blob/682f1b7a4f601c600f93284e4ac31087274987e0/MyRSSFeeds.UWP/ViewModels/MainViewModel.cs#L71-L78

Feeds search by title isn't very good at the moment because you need to write the title or a part of it exactly as it was to get a result

if the title was "Windows 7 is out of support" and searched for "windows" it won't return any thing to the user because the user will have to use "Windows"

some websites sometime send the xml rss file with it's first line as white space and c# XmlReader can't handle it so it crush and the app either can't add the rss as source or get the feed from it