ahilyard / merchantmarkers Goto Github PK

https://github.com/AHilyard/MerchantMarkers/blob/1.16.5/src/main/java/com/anthonyhilyard/merchantmarkers/render/Markers.java

At line 150: if (entity instanceof AbstractVillagerEntity)

If you detect IMerchant instead of AbstractVillagerEntity, this mod can support merchants from more mods. For example, the Goblin Merchant, whose goblin entity does not inherit AbstractVillagerEntity because it does not have Age, but goblin implements IMerchant.

In fact, after I modified this code with mixin, the whole mod worked quite well...

When using this mod with the Skyrim Soundpack, the music and UI sounds of the resource pack do not play.

Minecraft version: 1.20.1
Resource pack version: Skyrim Soundpack v6.1.zip
Mod version: MerchantMarkers-1.20.1-fabric-1.3.1

Title says all, latest version of both mods.

I am the Journeymap Dev, I looked through your integration. Thanks for adding it.
However, all of what you did with the mixins can be done with the EntityRadarUpdateEvent through our API.
https://github.com/TeamJM/journeymap-api/blob/1.16.5_1.8/src/main/java/journeymap/client/api/event/forge/EntityRadarUpdateEvent.java
examplemod:
https://github.com/TeamJM/journeymap-api/blob/5de6fda29c72992f1b806bb56c7475c727edd84a/src/main/java/example/mod/client/plugin/ForgeEventListener.java#L192

ExampleCode with how Pixelmon updates entity textures:

    @SubscribeEvent
    public void onRadarEntityUpdateEvent(EntityRadarUpdateEvent event) {
        LivingEntity entity = (LivingEntity)event.getWrappedEntity().getEntityLivingRef().get();
        if (entity instanceof PixelmonEntity) {
            PixelmonEntity pixelmon = (PixelmonEntity)entity;
            event.getWrappedEntity().setEntityIconLocation(pixelmon.getSprite());
        }
    }

is it possible to update this for fabric 1.18.2? :)

hi I am playing Minecolonies Dimension Adventure modpack 1.20.1 which is using MechantMarkers1.20.11.3.2 and Thaumia~0.6 BETA and anytime I press u/r on a item from Thaumia that shows a villager in a square with a recipe they will give for the item or what they will take to give the item it crashs my game to deaktop heres the crash report https://mclo.gs/ZWzCHPY

Without the mod, Minecraft takes roughly 25 seconds to launch. Applying this mod increased that to just over a minute and a half. The results were consistent. Tested three times.

latest.log

After using 1.20.1 version of merchant markers 1.3.1 Fabric, every time i boot the game and put resource packs, if i close the game and boot again it says resource loading failed and disables all my resource packs.

Hey there,

I really like the useful markers over every trader. Unfortunately the mod causes for MC 1.19.3 Forge 44.1.5. a wired issue when using a ressource pack.

Starting MC without an aktivated ressource pack MC seems to start normally. When starting MC with a previously activated ressource pack MC is crashing. You need to start MC again and MC is loaded without an activated ressource pack. Additionally a lot of mod configs, key binds etc... are resetted. Apparently you need to deactivate the ressource pack before closing MC to start MC without crashing again.

I'm getting the following crash log with this wired issue:

I'm making custom icons via KubeJS to add icons to modded professions. It works flawlessly with most, but for certain modded professions it does not work. One such villager profession is the Mushroom Trader from the Mushroom Villager Trader mod. This is definitely an issue with this mod as I've verified the ID of the custom villager professions, the KubeJS method works with other modded professions, and the other profession-altering mods I use work with the professions which are not compatible with custom icons, such as the Mushroom Trader. Any idea as to how I could fix this? I'm using Minecraft 1.20.1 with Forge 47.2.21 and Merchant Markers 1.3.3.

Can u try to realize another minimaps support like Xaero's Minimap?

1.18.2

Mod Related :

• MCA
• Xaero Minimap, World Map, Texture Compat

What's the issue you encountered?

Game stalls/freezes when booting(Mojang logo) when certain mods are used. Game must be closed manually.

How can the issue be reproduced?

Launch the game with some combination of mods applied, wait for the game to begin loading. Strangely, it appears as though the stall or freeze only happens 3/4 of the time but after testing on three separate systems I have confirmed that the issue is unlikely to be hardware related. I have tried to narrow down what mods are causing the issue and I have found that disabling either MerchantMarkers or a combination of the following mods can allow the game to boot:
-Effective
-Continuity
-Pipe
-Roughly Enough Items

However, launching the game with just those mods and MerchantMarkers(plus any required dependencies) does not result in a stall or freeze so there must be yet another conflict that I haven't been able to find. After messing about with this for a few hours I'm throwing in the towel, sorry I wasn't able to find the conflict, my hope is that you will have more luck given that you probably understand these things on a much deeper level.

Logs.

https://paste.ee/p/3zEXo

Multi-MC Instance Link.

https://drive.google.com/file/d/1sQ9mIBEc5m4mLdvKq8n92hDCA5QXQ9vQ/view?usp=sharing

Similiar to show player with Tab or user choosen keybind to show marker instead of always.

I could have sworn this mod had a 1.12.2 version that worked great.

Is it expected behaviour that I can see the icons through structures and blocks?

Caused by going near villages or spawning villagers.
Newest versions of Forge and Iceberg and tested without any other mods.

crash-2022-05-19_22.53.29-client.txt

I've recently been trying to add a Resource Pack which changes the music from the original minecraft discs, but while I was using this library and Merchant Markers. I'm not sure which one caused the compatibility issues with the Resource Pack so I'm gonna leave reports on both of these mods for you to investigate what caused the issues and if it was Merchant Markers instead.

I've spent hours making and changing the Resource Pack trying to find out what was wrong with it because I was doing everything right, until I tried it in a vanilla world, I found out it worked perfectly without the mods so I spent hours looking through my mods trying to find which mod was causing the issues and after a few tries I found out it was between Merchant Markers or Iceberg.

I also tried checking if it was because of me doing something wrong while making the Resource Pack by trying out a community made Resource Pack that changed the weather sounds (rain and thunder) and that also didn't work so I knew it wasn't because of me so it is because of the mod, it basically cancels any sound file that has changed with the resource pack.

This all happened in Java version, using forge (47.2.0) and the game version was 1.20.1.

Iceberg-1.20.1-forge-1.1.18
MerchantMarkers-1.20.1-forge-1.3.3

MC: 1.20.1
Forge: 47.2.1
MerchantMarkers: 1.3.2
JER: 1.4.0.238
JEI: 15.2.0.27

While checking the usage of an item, I looked under village trades (JER), when I received the below crash. For reference, this was done via the modpack BMC4.

crash-2023-11-03_00.01.48-client.txt

For some reason sounds will get disabled after 1-5 Minutes. Clicking through the sound sources fixes it. Disabling this mod too. What witchcraft of this mod is messing with the sounds?

Wynncraft with mods

ftb chunk version: 1605.3.2-build.115

Merchant markers version: 1.16.5 - 1.1.1

crash report message:
java.lang.Exception: Mod Loading has failed
at net.minecraftforge.fml.CrashReportExtender.dumpModLoadingCrashReport(CrashReportExtender.java:85) [?:?] {re:classloading}
at net.minecraftforge.fml.client.ClientModLoader.completeModLoading(ClientModLoader.java:188) [?:?] {re:classloading,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.lambda$null$1(Minecraft.java:508) [?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:mixins.betterthirdperson.json:MinecraftMixin,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:abnormals_core.mixins.json:client.MinecraftMixin,pl:mixin:APP:outer_end.mixins.json:BackgroundMusicMixin,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:globaldataandresourcepacks.mixins.json:ClientPackFinderMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft$$Lambda$12306/177522915.run(Unknown Source) [?:?] {}
at net.minecraft.util.Util.func_215077_a(Util.java:430) [?:?] {re:mixin,xf:OptiFine:default,re:classloading,xf:OptiFine:default,pl:mixin:APP:ftbchunks-common.mixins.json:UtilMixin,pl:mixin:A}
at net.minecraft.client.Minecraft.lambda$new$2(Minecraft.java:504) [?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:mixins.betterthirdperson.json:MinecraftMixin,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:abnormals_core.mixins.json:client.MinecraftMixin,pl:mixin:APP:outer_end.mixins.json:BackgroundMusicMixin,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:globaldataandresourcepacks.mixins.json:ClientPackFinderMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft$$Lambda$12032/1146980236.accept(Unknown Source) [?:?] {}
at net.minecraft.client.gui.ResourceLoadProgressGui.func_230430_a_(ResourceLoadProgressGui.java:172) [?:?] {re:classloading,xf:OptiFine:default}
at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:802) [?:?] {re:mixin,pl:accesstransformer:B,xf:OptiFine:default,re:classloading,pl:accesstransformer:B,xf:OptiFine:default,pl:mixin:APP:flywheel.mixins.json:StoreProjectionMatrixMixin,pl:mixin:A}
at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:977) [?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:mixins.betterthirdperson.json:MinecraftMixin,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:abnormals_core.mixins.json:client.MinecraftMixin,pl:mixin:APP:outer_end.mixins.json:BackgroundMusicMixin,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:globaldataandresourcepacks.mixins.json:ClientPackFinderMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) [?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:mixins.betterthirdperson.json:MinecraftMixin,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:abnormals_core.mixins.json:client.MinecraftMixin,pl:mixin:APP:outer_end.mixins.json:BackgroundMusicMixin,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:globaldataandresourcepacks.mixins.json:ClientPackFinderMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:184) [?:?] {re:classloading,pl:runtimedistcleaner:A}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51] {}
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) [forge-1.16.5-36.2.22.jar:36.2] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$504/1713596938.call(Unknown Source) [forge-1.16.5-36.2.22.jar:36.2] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Render thread
Stacktrace:
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {re:classloading}
-- MOD ftbchunks --
Details:
Caused by 0: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:250) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.service.modlauncher.MixinTransformationHandler.processClass(MixinTransformationHandler.java:131) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.launch.MixinLaunchPluginLegacy.processClass(MixinLaunchPluginLegacy.java:131) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at cpw.mods.modlauncher.serviceapi.ILaunchPluginService.processClassWithFlags(ILaunchPluginService.java:154) ~[modlauncher-8.0.9.jar:8.0.9+86+master.3cf110c] {}
at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:85) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.TransformingClassLoader$DelegatedClassLoader.findClass(TransformingClassLoader.java:265) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:136) ~[modlauncher-8.0.9.jar:?] {re:classloading}
at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:98) ~[modlauncher-8.0.9.jar:?] {re:classloading}
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_51] {}
at dev.ftb.mods.ftbchunks.FTBChunks.lambda$new$0(FTBChunks.java:112) ~[?:1605.3.2-build.115] {re:mixin,re:classloading}
at dev.ftb.mods.ftbchunks.FTBChunks$$Lambda$6848/805028239.get(Unknown Source) ~[?:?] {}
at me.shedaniel.architectury.utils.EnvExecutor.getEnvSpecific(EnvExecutor.java:53) ~[?:?] {re:classloading}
at dev.ftb.mods.ftbchunks.FTBChunks.(FTBChunks.java:112) ~[?:1605.3.2-build.115] {re:mixin,re:classloading}
at dev.ftb.mods.ftbchunks.forge.FTBChunksForge.(FTBChunksForge.java:14) ~[?:1605.3.2-build.115] {re:classloading}
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0_51] {}
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:1.8.0_51] {}
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:1.8.0_51] {}
at java.lang.reflect.Constructor.newInstance(Constructor.java:422) ~[?:1.8.0_51] {}
at java.lang.Class.newInstance(Class.java:442) ~[?:1.8.0_51] {}
at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:81) ~[?:36.2] {re:classloading}
at net.minecraftforge.fml.javafmlmod.FMLModContainer$$Lambda$3194/610123017.run(Unknown Source) ~[?:?] {}
at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:120) ~[?:?] {re:classloading}
at net.minecraftforge.fml.ModContainer$$Lambda$3313/1979961282.run(Unknown Source) ~[?:?] {}
at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1618) ~[?:1.8.0_51] {}
at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1610) ~[?:1.8.0_51] {}
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[?:1.8.0_51] {}
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) ~[?:1.8.0_51] {}
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1689) ~[?:1.8.0_51] {re:computing_frames}
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) ~[?:1.8.0_51] {}

Mod File: ftb-chunks-forge-1605.3.2-build.115.jar
Failure message: FTB Chunks (ftbchunks) has failed to load correctly
	org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
Mod Version: 1605.3.2-build.115
Mod Issue URL: https://github.com/FTBTeam/FTB-Chunks/issues
Exception message: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector redirectGetType(Lnet/minecraft/entity/Entity;)Lnet/minecraft/entity/EntityType; in merchantmarkers.mixins.json:FTBChunksClientMixin failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap merchantmarkers.refmap.json

Stacktrace:
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {re:classloading}
at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1362) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1051) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:400) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:383) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:365) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:250) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.service.modlauncher.MixinTransformationHandler.processClass(MixinTransformationHandler.java:131) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at org.spongepowered.asm.launch.MixinLaunchPluginLegacy.processClass(MixinLaunchPluginLegacy.java:131) ~[mixin-0.8.4.jar:0.8.4+Jenkins-b308.git-2accda5000f7602229606b39437565542cc6fba4] {}
at cpw.mods.modlauncher.serviceapi.ILaunchPluginService.processClassWithFlags(ILaunchPluginService.java:154) ~[modlauncher-8.0.9.jar:8.0.9+86+master.3cf110c] {}
at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:85) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.TransformingClassLoader$DelegatedClassLoader.findClass(TransformingClassLoader.java:265) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:136) ~[modlauncher-8.0.9.jar:?] {re:classloading}
at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:98) ~[modlauncher-8.0.9.jar:?] {re:classloading}
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_51] {}
at dev.ftb.mods.ftbchunks.FTBChunks.lambda$new$0(FTBChunks.java:112) ~[?:1605.3.2-build.115] {re:mixin,re:classloading}
at dev.ftb.mods.ftbchunks.FTBChunks$$Lambda$6848/805028239.get(Unknown Source) ~[?:?] {}
at me.shedaniel.architectury.utils.EnvExecutor.getEnvSpecific(EnvExecutor.java:53) ~[?:?] {re:classloading}
at dev.ftb.mods.ftbchunks.FTBChunks.(FTBChunks.java:112) ~[?:1605.3.2-build.115] {re:mixin,re:classloading}
at dev.ftb.mods.ftbchunks.forge.FTBChunksForge.(FTBChunksForge.java:14) ~[?:1605.3.2-build.115] {re:classloading}
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0_51] {}
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:1.8.0_51] {}
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:1.8.0_51] {}
at java.lang.reflect.Constructor.newInstance(Constructor.java:422) ~[?:1.8.0_51] {}
at java.lang.Class.newInstance(Class.java:442) ~[?:1.8.0_51] {}
at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:81) ~[?:36.2] {re:classloading}
at net.minecraftforge.fml.javafmlmod.FMLModContainer$$Lambda$3194/610123017.run(Unknown Source) ~[?:?] {}
at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:120) ~[?:?] {re:classloading}
at net.minecraftforge.fml.ModContainer$$Lambda$3313/1979961282.run(Unknown Source) ~[?:?] {}
at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1618) ~[?:1.8.0_51] {}
at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1610) ~[?:1.8.0_51] {}
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[?:1.8.0_51] {}
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) ~[?:1.8.0_51] {}
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1689) ~[?:1.8.0_51] {re:computing_frames}
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) ~[?:1.8.0_51] {}

-- System Details --
Details:
Minecraft Version: 1.16.5
Minecraft Version ID: 1.16.5
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 3783374504 bytes (3608 MB) / 5335154688 bytes (5088 MB) up to 8589934592 bytes (8192 MB)
CPUs: 12
JVM Flags: 10 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -XX:+IgnoreUnrecognizedVMOptions -Xmx8G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
ModLauncher: 8.0.9+86+master.3cf110c
ModLauncher launch target: fmlclient
ModLauncher naming: srg
ModLauncher services:
/mixin-0.8.4.jar mixin PLUGINSERVICE
/eventbus-4.0.0.jar eventbus PLUGINSERVICE
/forge-1.16.5-36.2.22.jar object_holder_definalize PLUGINSERVICE
/forge-1.16.5-36.2.22.jar runtime_enum_extender PLUGINSERVICE
/accesstransformers-3.0.1.jar accesstransformer PLUGINSERVICE
/forge-1.16.5-36.2.22.jar capability_inject_definalize PLUGINSERVICE
/forge-1.16.5-36.2.22.jar runtimedistcleaner PLUGINSERVICE
/mixin-0.8.4.jar mixin TRANSFORMATIONSERVICE
/OptiFine_1.16.5_HD_U_G8.jar OptiFine TRANSFORMATIONSERVICE
/forge-1.16.5-36.2.22.jar fml TRANSFORMATIONSERVICE

1.18.2, with MCA Villagers

I have tested with and with out this mod and yes it causes the issue

https://mclo.gs/WWEX0M7

Consulting with the FTB team, and they mentioned that
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector redirectIconDraw(Ldev/ftb/mods/ftbchunks/integration/MapIcon;Ldev/ftb/mods/ftbchunks/client/MapType;Lnet/minecraft/class_4587;IIIIZ)V in merchantmarkers.mixins.json:FTBChunksClientMixin from mod merchantmarkers failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap MerchantMarkers-1.19.1-fabric-refmap.json

Is mixing into their mod which is causing the crash.

If you pickup a villager with the a marker above them and then go into third person your game will crash

Forge Version 40.1.68
Mods Involved
MerchantMarkers-1.18.2-1.2.2.jar
Iceberg-1.18.2-forge-1.0.48.jar
carryon-1.18.2-1.17.0.8.jar

Logs

latest.log
debug.log

Crash Report
crash-2022-10-17_17.17.28-client.txt

https://streamable.com/azbje7

For some reason my game all of a sudden crashes when starting and always gives me this crash.
I'm aware that the problem has to do with optifine but there are weirdly enough multiple way of not making it crash on start up.

• Removing the my own texturepack that I made from my folder(the crash only happens when it is selected before closing the game)
• Removing Optifine
• Removing Merchant Markers(Which is so confusing to me because the Texturepack changes nothing about Merchant Markers + it always worked fine up till now(I even re install, generated a new config and made a new client))

crash-2023-06-28_21.09.43-client.txt

Howdy!

I'm experiencing a strange issue with version 1.18.2-1.3.0 on forge 40.2.1 where the game will sit at 15-20 fps when playing normally, but the lag disappears entirely with the debug screen open. Not sure what could be causing this, I've never encountered this issue before with a mod.

Thanks and let me know if I can offer any assistance!