Git Product home page Git Product logo

require-style's Introduction

require-style's People

Contributors

ahdinosaur avatar arj03 avatar christianbundy avatar dependabot[bot] avatar mixmix avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

require-style's Issues

windows

doesn't quite work with font-awesome in windows yet.

error looks like erorr, can't find :

file:///C:/Usersmixmixprojectspatchbaynode_modules%0Font-awesome%0Fonts/fontawesome-webfont.woff2?v=4.7.0

Require-style breaks when directory contains spaces

How to reproduce

Install patchbay under a directory path that includes spaces, e.g. '/Users/tim/Large Files/src/patchbay/'

Symptoms (in patchbay)

FontAwesome is not loaded in patchbay so Filter icons are rendered as plain squares.

Details

The main body of the css file starts:

@font-face { font-family: 'FontAwesome'; src: url('../fonts/fontawesome-webfont.eot?v=4.7.0'); src: url('../fonts/fontawesome-webfont.eot?#iefix&v=4.7.0') format('embedded-opentype'),

Using the console you can see that urls are not enclosed in single quotes

>>requireStyle('font-awesome').substring(212,400)

"@font-face { font-family: 'FontAwesome'; src: url(/Users/tim/Large Files/src/patchbay/node_modules/font-awesome/fonts/fontawesome-webfont.eot?v=4.7.0); src: url(/Users/tim/Large File"

An earlier version of patchbay used fs.readFileSync() which works. For comparison the console output is below

>>readFileSync(fontCssPath, 'utf8') .replace(/\.{2}/g, (match) => join(dirname(fontCssPath), match)).substring(212,400)

"@font-face { font-family: 'FontAwesome'; src: url('/Users/tim/Large Files/src/patchbay/node_modules/font-awesome/fonts/fontawesome-webfont.eot?v=4.7.0'); src: url('/Users/tim/Large F"

Workaround

Don't install patchbay under a directory path that includes spaces :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.