aganders3 / headless-gui Goto Github PK

hey @aganders3

One challenge that always popped up with setup-xvfb is that of trying to use conda-incubator/setup-miniconda to install certain dependencies. (e.g. if you can't use all pip for some reason).

When using https://github.com/conda-incubator/setup-miniconda/ ... one generally has to use shell: bash -el {0} when running a command to access the conda environment. This appears to be hard to do with @actions/exec.exec. To demonstrate the problem:

jobs:
  test:
    runs-on: ubuntu-latest
    defaults:
      run:
        shell: bash -l {0}  # for setup-miniconda
    steps:
      - uses: actions/checkout@v2
      - uses: conda-incubator/setup-miniconda@v2
        with:
          mamba-version: "*"
          channels: conda-forge
          channel-priority: strict
          python-version: '3.10'
      - name: Print python
        run: which python  # prints: /usr/share/miniconda/envs/test/bin/python 

      - name: Print from headless-gui
        uses: aganders3/headless-gui@v1
        with:
          run: which python  # prints /usr/bin/python

... so basically one can't access the miniconda environment from within the headless-gui context.

This is likely a shortcoming of https://github.com/actions/toolkit/tree/main/packages/exec (see actions/toolkit#229 ...), but curious if you have any thoughts on a workaround?

FYI: actions are warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: aganders3/headless-gui@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Haven't been able to figure this out yet, but I've been noticing that all of the ubuntu-latest pyqt6 tests are immediately failing with Aborted (core dumped). see example: https://github.com/pyapp-kit/superqt/actions/runs/4998490149

I did try logging in to my own linux box and setting up a similar environment, I got the same result (just with pyqt6), on the first test that tries to run (doesn't matter which, I can ignore/select anything and it always fails the same way). However, if I use xvfb-run pytest, instead of starting an Xvfb server, it seems to work fine.

I know that's not a lot to go on 😂 ... but might possibly indicative of an annoying issue. It may very well also be specific to superqt (haven't tested a minimal example yet on CI).

I don't think it is necessary for running the action, and if needed for debugging it could still be added locally. Right now I feel lit just creates noise in the diffs.

GabrielBB/xvfb-action supported an optional working-directory: to run commands in a different directory from the root. This can be important to set for certain commands such as running jupyter notebooks, because run: cd some-dir doesn't work. It would be good for headless-gui to support this argument as well! 🙏