agamm / download-http Goto Github PK

The code should wait until the writeStream emits the "finished" event before calling the user-provided callback. Otherwise, the callback is in a race condition and can't rely on the contents of the file actually being there.

This is not a good way to determine if an absolute path is given:

path.extname(destination).length > 0

This is what's used in the getSavePath function, but what if I want to download to a filename that doesn't have an extension (e.g., 'README' or '.bashrc' in which case my destination is absolute) or to a directory that has a dot in the name (in which case my destination is not absolute)? In any of these cases, your test will fail and not behave as desired.

Would rather pass in an object with a 'dir' and an optional 'filename', for instance, so I can be explicit about what I want. Alternatively, you could say that it's absolute unless it ends with a trailing slash, which would indicate a directory destination.