aftership / aftership-sdk-go Goto Github PK

Hi, go mod requires tags to start with a "v" prefix.
go get will end up with v2.0.4 as newer versions don't have the 'v' prefix and meanwhile we target specific commits.

Currently, the API client fails to process an error response from the create tracking endpoint.

Steps to reproduce:

package main

import (
	"context"
	"fmt"
	"time"

	"github.com/aftership/aftership-sdk-go/v2"
)

func main() {
	unauthorizedTracker, err := aftership.NewClient(aftership.Config{APIKey: "UNAUTHORIZED"})
	if err != nil {
		panic(err)
	}

	_, err = unauthorizedTracker.CreateTracking(context.Background(),
		aftership.CreateTrackingParams{Slug: []string{"total-express"}, TrackingNumber: time.Now().String()})

	fmt.Println(err)
}

Expected behaviour

The function call should return an error of type APIError that contains the error code and error message ("unauthorized").

Actual behaviour

Returns the unstructured error:

error unmarshalling the JSON response: json: cannot unmarshal array into Go struct field Tracking.data.tracking.slug of type string

As far as I understand, the problem arises from line 78 in requests.go file, where we try to unmarshal the response. The expected response has field Tracking.Slug of type string, while the received type is a slice of strings.

test send slack msg