afanasy / db3 Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 1.0 97 KB

Communication framework

License: MIT License

JavaScript 100.00%

db3's People

Stargazers

Watchers

Forkers

ragnardanneskjold

db3's Issues

Add transform streams.

Add converting {from: from, to: to} to SQL "between".

Add BigTable support.

Add browser SQL support.

Add addField, modifyField, changeField, dropField calls.

Add example for multiple inserts.

Add skipField parameter to save call to skip fields in "update" part of query.

Needed to skip "created" field.

GroupBy method parses fields incorrectly if it is more than one field

  field = _.map(field, function (d, i) {return mysql.escapeId(field)}).join(', ')

should be

  field = _.map(field, function (d, i) {return mysql.escapeId(d)}).join(', ')

Add support for array cond for update.

Add .change(filter, callback) method

It should be called when data matching filter (handled by db3-where) has been changed with insert/update/delete (and truncate/drop table in the future)

Node frendly functions

before example from your test.js

  before(function (done) {
    db.dropTable('test', function () {
      db.createTable('test', function () {
        db.dropTable('person', function () {
          db.createTable('person', ['id', 'name', 'gender'], function () {
            async.eachSeries(person, function (item, done) {db.insert('person', item, function () {done()})}, done)
          })
        })
      })
    })
  })

but users want to use async here:

before(function (done) {
  async.series([
    db.dropTable.bind(db, 'test'),
    db.createTable.bind(db, 'test'),
    db.dropTable.bind(db, 'person'),
    db.createTable.bind(db, 'person'),
    async.series.bind(async, person, db.insert.bind(db, 'person'));
  ], done);
});

this is impossible with your api, because you pass result as first arg, but node convention waits err as first argument.

After you start to support node style you feel free to add some other features to your functions call. It may be promises or carreing

For example after carreing, previous code will look like:

before(function (done) {
  async.series([
    db.dropTable('test'),
    db.createTable('test'),
    db.dropTable('person'),
    db.createTable('person'),
    async.eachSeries.bind(async, person, db.insert('person'));
  ], done);
});

Or shortly:

function series() {
  return async.series.bind.apply(async.series, [async].concat(arguments));
}
function map(obj, func) {
  return Object.keys(obj).map(function(key) {
    return func(obj[key]);
  })
}
before(series([
  db.dropTable('test'),
  db.createTable('test'),
  db.dropTable('person'),
  db.createTable('person'),
  series(map(person, db.insert('person')));
]));

Look at ramda if you want to expose functional programming api in your lib.

So using promises your before statement can look like:

before(function(done) {
  db.dropTable('test')
    .createTable('test')
    .dropTable('person')
    .createTable('person')
    .then(function(resolve, reject) {
      async.eachSeries(person, db.insert.bind(db, 'person'), function(err, result) {
        if (err) return reject(err);

        resolve(result)
      });
    })
    .then(done);
});

So keep in mind, that I don't read all your code at current time. This is only fast review and maybe I missed the main reason why you doesn't use node function style.

db.createTable('person', function(error, result) {
  // result is Table object
  // or maybe result contains table object

  //result.table.select
  result.select({name: 'Bob'}, ['name', 'gender'], function (error, data) {
    if (error) 
      return console.error(error);

    console.log('selected name, gender fields from table `person`, where `name` = "Bob"')
    console.log(data)
  })
})

afanasy / db3 Goto Github PK

db3's People

Stargazers

Watchers

Forkers

db3's Issues

Recommend Projects

Recommend Topics

Recommend Org