aespinilla / faparser Goto Github PK

Hola.
En NPM está la versión 1.0.0, que tiene el bug de los directores.

Un saludo y muchas gracias por este gran paquete.

Hello,

I've been using your package for some time now but it recently (not sure exactly when in the last X months) stopped working.

Seems to be something due with this line when submitting the following request:

{
    query: "the matrix",
    lang: 'uk',
    type: fa.TITLE,
    start: 0,
  }

the error received is:

TypeError: Cannot read property 'filter' of undefined
    at .../src/node_modules/faparser/node_modules/cheerio/lib/api/traversing.js:30:42
    at Array.reduce (<anonymous>)
    at module.exports.exports.find (.../src/node_modules/faparser/node_modules/cheerio/lib/api/traversing.js:29:30)
    at Object.parseSearch (.../src/node_modules/faparser/parser.js:233:17)
    at .../src/node_modules/faparser/faparser.js:24:35
    ....

It was working on your version 1.0.6 which uses cheerio 1.0.0-rc.3 but stopped with 1.0.8 that is using cheerio 1.0.0-rc.5.

I've never used cheerio that it's hard for me to go deeper and find what's wrong.
Appreciate the feedack!

Cheers
Joel

Hello again :-)

I see you changed the deprecated request package for bent. This had the unfortunate effect of not supporting redirects anymore.

A search like this: https://www.filmaffinity.com/uk/search.php?stype=title&stext=alien%20tv&from=0&orderby=year that used to be supported and parsed by your package now fails with the following:

{
  code: 303,
  url: 'https://www.filmaffinity.com/uk/search.php?stype=title&stext=alien%20tv&from=0&orderby=year',
  error: 'See Other'
}

Unfortunately, I couldn't see options for bent to support redirects.

There are other good packages out there though and I'm myself using quite a lot superagent that supports redirects.

Would it possible to make that change?

Cheers
Joel

Hello,

I noticed that some ratings returned under the following string format --. I can't know for sure if this was already the case with the previous version.

Also, the prop votes can return an empty string (see image below).

I would suggest having an aligned way of dealing with empty data by passing null. This makes it much easier to post process and avoid having some kind of mapping for each property.

Cheers
Joel

Hello,

Would it be possible to pass in a config option such as log: false in order to deactivate the logging going on inside of this module?

Many thanks,
Joel