Git Product home page Git Product logo

chroma's People

Contributors

aeroluna avatar binaryelement avatar plasmapower avatar top-cat avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

chroma's Issues

older maps breaking on new chroma versions

Older maps do not work like they used to (bad apple by peecore and nulcrtl by reactx ect.) do not work like they used to. I have tested them with game version 1.13.2 (resetting my game save while doing so) and they worked as expected.

Doesnt work.

It does not show up in the mod assistant and if i install it manually (downloading last build from releases and copying dll into plugins folder) my maps arent working anymore they have only at the start 1 block and after that the map is empty... Tryd reinstalling game + mod assistant multiple times.

Colors not enforcing properly

I made a NE / Chroma map, and noticed that different people are getting one of two sets of colors.

The map colors are green / blue, but some people are getting red / black when playing it (that changes later when colors are animated). The map is setting the colors properly in the info.dat, and Override Default Colors is asked to be off by _heck.

Map ID:
https://beatsaver.com/maps/1ddab

Red/Black: https://www.twitch.tv/videos/1205408987?sr=a&t=19490s

The colors displayed for me (regardless if override default colors is on or not) are green/blue though: https://drive.google.com/file/d/1aweDU69afGUnNmbXxBRhneHbrFfRCEa9/view?usp=sharing

Unclear that Heck is a required dependency

It's unclear that Heck is now a required dependency for this plugin, as well as for NoodleExtensions. This caused both myself and a friend of mine confusion for a long time, until I looked at the log and figured it from there. I am requesting that a blurb should be added to the readme indicating the dependency plugins.

Right Hand Phasing Through Blocks

I know this sounds dumb, as Chroma is a lighting mod and shouldn't affect gameplay whatsoever but I keep having an issue where whenever I have Chroma lighting effects enabled on a chart (only some charts, only some of the time) my right hand phases through blocks without cutting them. It plays the block cut sound and shows me my score for the cut, but counts as a miss. As soon as I disable Chroma, it goes back to normal. I honestly have no idea what the issue is, help would be appreciated!

Lightshow mode doesn't remove blocks on maps using NoodleExtensions

I haven't drilled down 100% which maps are affected and which are not, but the pattern across all maps I've tested has been NE wallmaps (such as Unholy Crusade) will still have blocks, while on other maps, including wallmaps using MappingExtensions instead, the blocks are removed. In all cases, the sabers are disabled.

Issues with some of the maps

so using this chroma won't let the song consistently change colors, like in Zomboy - EndGame, or in Chasing Colors, so if there is a way to fix this let me know, brain empty

Chroma in plugins folder but not working in-game

Hey. I just downloaded both noodle extensions and chroma and then put both in the plugins folder but when I load up the game they don't pop up or work (Still says missing requirement on maps). Is it to do with the patch notes saying added dependency to Heck? As if so i'm not 100% sure what that is

360 Degree Map Bug

If I use the newest pre-release version of Chroma, all 360 Degree Maps aren't working anymore. I can't press the Play button.
Chroma Version v2.4.1 is not working, however v2.4.0 is working fine! All other mods are up to date and the newest Noodle Extensions is installed too.

Exception on note cut

When playing on a Chroma enabled map successful cuts are being shown as misses, with following stacktrace thrown:

[CRITICAL @ 02:03:30 | UnityEngine] InvalidOperationException: Could not find SaberColorizer
[CRITICAL @ 02:03:30 | UnityEngine] Chroma.Colorizer.ColorizerExtensions.TryGetSaberColorizer (SaberType saber, System.Collections.Generic.List`1[Chroma.Colorizer.SaberColorizer]& colorizer) (at <ff0c8e3ad0b24d1ca3154590d4cd9fbd>:0)
[CRITICAL @ 02:03:30 | UnityEngine] Chroma.Colorizer.ColorizerExtensions.ColorizeSaber (SaberType saber, System.Nullable`1[T] color) (at <ff0c8e3ad0b24d1ca3154590d4cd9fbd>:0)
[CRITICAL @ 02:03:30 | UnityEngine] Chroma.Colorizer.NoteColorizer.ColorizeSaber (NoteController noteController, NoteCutInfo& noteCutInfo) (at <ff0c8e3ad0b24d1ca3154590d4cd9fbd>:0)
[CRITICAL @ 02:03:30 | UnityEngine] BeatmapObjectManager.HandleNoteControllerNoteWasCut (NoteController noteController, NoteCutInfo& noteCutInfo) (at <2d05f8f85bbd4e6e9f302448a1c041d2>:0)
[CRITICAL @ 02:03:30 | UnityEngine] BeatmapObjectManager.INoteControllerNoteWasCutEvent.HandleNoteControllerNoteWasCut (NoteController noteController, NoteCutInfo& noteCutInfo) (at <2d05f8f85bbd4e6e9f302448a1c041d2>:0)
[CRITICAL @ 02:03:30 | UnityEngine] NoteController.SendNoteWasCutEvent (NoteCutInfo& noteCutInfo) (at <2d05f8f85bbd4e6e9f302448a1c041d2>:0)
[CRITICAL @ 02:03:30 | UnityEngine] GameNoteController.HandleCut (Saber saber, UnityEngine.Vector3 cutPoint, UnityEngine.Quaternion orientation, UnityEngine.Vector3 cutDirVec, System.Boolean allowBadCut) (at <2d05f8f85bbd4e6e9f302448a1c041d2>:0)
[CRITICAL @ 02:03:30 | UnityEngine] GameNoteController.HandleBigWasCutBySaber (Saber saber, UnityEngine.Vector3 cutPoint, UnityEngine.Quaternion orientation, UnityEngine.Vector3 cutDirVec) (at <2d05f8f85bbd4e6e9f302448a1c041d2>:0)
[CRITICAL @ 02:03:30 | UnityEngine] CuttableBySaber.CallWasCutBySaberEvent (Saber saber, UnityEngine.Vector3 cutPoint, UnityEngine.Quaternion orientation, UnityEngine.Vector3 cutDirVec) (at <2d05f8f85bbd4e6e9f302448a1c041d2>:0)
[CRITICAL @ 02:03:30 | UnityEngine] BoxCuttableBySaber.Cut (Saber saber, UnityEngine.Vector3 cutPoint, UnityEngine.Quaternion orientation, UnityEngine.Vector3 cutDirVec) (at <2d05f8f85bbd4e6e9f302448a1c041d2>:0)
[CRITICAL @ 02:03:30 | UnityEngine] (wrapper dynamic-method) NoteCutter.NoteCutter.Cut_Patch1(NoteCutter,Saber)
[CRITICAL @ 02:03:30 | UnityEngine] CuttingManager.HandleSaberManagerDidUpdateSaberPositions (Saber leftSaber, Saber rightSaber) (at <2d05f8f85bbd4e6e9f302448a1c041d2>:0)
[CRITICAL @ 02:03:30 | UnityEngine] SaberManager.Update () (at <2d05f8f85bbd4e6e9f302448a1c041d2>:0)

This does not happen on the first map after starting Beat Saber, but on every subsequent one.
For custom sabers I'm using SaberFactory 1.6.4 (V1 legacy edition), but it also happens on the new SaberFactory releases.
Latest version of Chroma. Disabling Chroma events fixes the issue.

Won't let me hit the blocks.

sighs i've looked everywhere for answers to why (on Noodle Extension maps) when the notes/sabers change colour and a hit a note it says "Miss" My recorded that I use is broken but here is the logs for chroma:
_latest.log

but that might not help so here is a log of the game:
_latest.log

i hope you can help Aeroluna. But if you cant that's fine

ok bye i must go and cry in a dark corner in my room

Chroma wont work at all

I have chroma in the plugins folder and noodle extensions installed but it doesn't even show up in the game that its even working.
I have ran the IPA and everything it's just not working

Green Day Grenade environment preventing song start on 1.15.0

When trying to play a song that uses the Green Day Grenade environment (or forcing it through player settings), clicking "Play" does not start the song and instead starts creating framerate issues (???). Changing the environment fixes the issue, and so does removing the mod.

Here's what seems to be the relevant bits of log:

[CRITICAL @ 22:08:27 | UnityEngine] ArgumentNullException: Value cannot be null.
[CRITICAL @ 22:08:27 | UnityEngine] Parameter name: dictionary
[CRITICAL @ 22:08:27 | UnityEngine] System.Collections.Generic.Dictionary`2[TKey,TValue]..ctor (System.Collections.Generic.IDictionary`2[TKey,TValue] dictionary, System.Collections.Generic.IEqualityComparer`1[T] comparer) (at <9577ac7a62ef43179789031239ba8798>:0)
[CRITICAL @ 22:08:27 | UnityEngine] System.Collections.Generic.Dictionary`2[TKey,TValue]..ctor (System.Collections.Generic.IDictionary`2[TKey,TValue] dictionary) (at <9577ac7a62ef43179789031239ba8798>:0)
[CRITICAL @ 22:08:27 | UnityEngine] Chroma.LightIDTableManager+<>c.<SetEnvironment>b__3_0 (System.Collections.Generic.Dictionary`2[TKey,TValue] n) (at <be09fce8331d476d83e886a7d2978034>:0)
[CRITICAL @ 22:08:27 | UnityEngine] System.Linq.Enumerable+SelectArrayIterator`2[TSource,TResult].ToArray () (at <351e49e2a5bf4fd6beabb458ce2255f3>:0)
[CRITICAL @ 22:08:27 | UnityEngine] System.Linq.Enumerable.ToArray[TSource] (System.Collections.Generic.IEnumerable`1[T] source) (at <351e49e2a5bf4fd6beabb458ce2255f3>:0)
[CRITICAL @ 22:08:27 | UnityEngine] Chroma.LightIDTableManager.SetEnvironment (System.String environmentName) (at <be09fce8331d476d83e886a7d2978034>:0)
[CRITICAL @ 22:08:27 | UnityEngine] Chroma.HarmonyPatches.SceneTransitionHelper.SetEnvironmentTable (EnvironmentInfoSO environmentInfo) (at <be09fce8331d476d83e886a7d2978034>:0)
[CRITICAL @ 22:08:27 | UnityEngine] (wrapper dynamic-method) StandardLevelScenesTransitionSetupDataSO.StandardLevelScenesTransitionSetupDataSO.Init_Patch4(StandardLevelScenesTransitionSetupDataSO,string,IDifficultyBeatmap,IPreviewBeatmapLevel,OverrideEnvironmentSettings,ColorScheme,GameplayModifiers,PlayerSpecificSettings,PracticeSettings,string,bool)
[CRITICAL @ 22:08:27 | UnityEngine] (wrapper dynamic-method) MenuTransitionsHelper.MenuTransitionsHelper.StartStandardLevel_Patch1(MenuTransitionsHelper,string,IDifficultyBeatmap,IPreviewBeatmapLevel,OverrideEnvironmentSettings,ColorScheme,GameplayModifiers,PlayerSpecificSettings,PracticeSettings,string,bool,System.Action,System.Action`1<Zenject.DiContainer>,System.Action`2<StandardLevelScenesTransitionSetupDataSO, LevelCompletionResults>)
[CRITICAL @ 22:08:27 | UnityEngine] MenuTransitionsHelper.StartStandardLevel (System.String gameMode, IDifficultyBeatmap difficultyBeatmap, IPreviewBeatmapLevel previewBeatmapLevel, OverrideEnvironmentSettings overrideEnvironmentSettings, ColorScheme overrideColorScheme, GameplayModifiers gameplayModifiers, PlayerSpecificSettings playerSpecificSettings, PracticeSettings practiceSettings, System.String backButtonText, System.Boolean useTestNoteCutSoundEffects, System.Action beforeSceneSwitchCallback, System.Action`2[T1,T2] levelFinishedCallback) (at <636b4ece40dd4dd7b3f50d461344187a>:0)
[CRITICAL @ 22:08:27 | UnityEngine] SinglePlayerLevelSelectionFlowCoordinator.StartLevel (System.Action beforeSceneSwitchCallback, System.Boolean practice) (at <636b4ece40dd4dd7b3f50d461344187a>:0)
[CRITICAL @ 22:08:27 | UnityEngine] SinglePlayerLevelSelectionFlowCoordinator.StartLevelOrShow360Prompt (System.Action beforeSceneSwitchCallback, System.Boolean practice) (at <636b4ece40dd4dd7b3f50d461344187a>:0)
[CRITICAL @ 22:08:27 | UnityEngine] SinglePlayerLevelSelectionFlowCoordinator.ActionButtonWasPressed () (at <636b4ece40dd4dd7b3f50d461344187a>:0)
[CRITICAL @ 22:08:27 | UnityEngine] LevelSelectionFlowCoordinator.HandleLevelSelectionNavigationControllerDidPressActionButton (LevelSelectionNavigationController viewController) (at <636b4ece40dd4dd7b3f50d461344187a>:0)
[CRITICAL @ 22:08:27 | UnityEngine] LevelSelectionNavigationController.HandleLevelCollectionNavigationControllerDidPressActionButton (LevelCollectionNavigationController viewController) (at <636b4ece40dd4dd7b3f50d461344187a>:0)
[CRITICAL @ 22:08:27 | UnityEngine] LevelCollectionNavigationController.HandleLevelDetailViewControllerDidPressActionButton (StandardLevelDetailViewController viewController) (at <636b4ece40dd4dd7b3f50d461344187a>:0)
[CRITICAL @ 22:08:27 | UnityEngine] StandardLevelDetailViewController.<DidActivate>b__47_0 () (at <636b4ece40dd4dd7b3f50d461344187a>:0)
[CRITICAL @ 22:08:27 | UnityEngine] UnityEngine.Events.InvokableCall.Invoke () (at <12e76cd50cc64cf19e759e981cb725af>:0)
[CRITICAL @ 22:08:27 | UnityEngine] UnityEngine.Events.UnityEvent.Invoke () (at <12e76cd50cc64cf19e759e981cb725af>:0)
[CRITICAL @ 22:08:27 | UnityEngine] UnityEngine.UI.Button.Press () (at <0715729883c64e74bf9334ddb6a92401>:0)
[CRITICAL @ 22:08:27 | UnityEngine] UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <0715729883c64e74bf9334ddb6a92401>:0)
[CRITICAL @ 22:08:27 | UnityEngine] UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <0715729883c64e74bf9334ddb6a92401>:0)
[CRITICAL @ 22:08:27 | UnityEngine] UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <0715729883c64e74bf9334ddb6a92401>:0)
[CRITICAL @ 22:08:27 | UnityEngine] UnityEngine.EventSystems.ExecuteEvents:Execute(GameObject, BaseEventData, EventFunction`1)
[CRITICAL @ 22:08:27 | UnityEngine] VRUIControls.VRInputModule:ProcessMousePress(MouseButtonEventData)
[CRITICAL @ 22:08:27 | UnityEngine] VRUIControls.VRInputModule:Process()
[CRITICAL @ 22:08:27 | UnityEngine] UnityEngine.EventSystems.EventSystem:Update()

Here's a full log file for good measure:

2021.04.29.22.07.22.log

Mod Not being Detected (Steam)

I put the .dll into the plugins folder. It didn't do anything. I have the noodle extensions mod and it is working perfectly. I also have the required "CustomJSONData.dll" as well. I just downloaded and tried it. I restarted the game and steam vr multiple times.

Build instruction

I would love to be able to test this, but I can't figure out how to get my visual studio set up. Are there build instructions anywhere, it looks like this thing octopuses around all over the place.

I got as far as to figure out where to put noodle, but I can't figure out how to get/put style cop where it needs to go or resolve any of the missing mod references.

(Check out noodle to the same folder as this.)

Edit: Use mod assistant to install the base layout of mods, make sure to get stuff like SiraUtil CustomJSONData, etc. As you find missing references, see if you can use the mod assistant to install the reference.

git clone https://github.com/Aeroluna/Chroma --recurse-submodules
git clone https://github.com/Aeroluna/Heck--recurse-submodules
git clone https://github.com/Aeroluna/NoodleExtensions --recurse-submodules

Add option to remove block color enforcement

If possible, please add the option to disable the block colors enforcement. Just like it is possible to play with static lights on a chroma map. It would be great to be able to use personal block colors on Chroma required maps since the play button is greyed out if I try to disable the mod.

Sometimes the colors a mapper picks can be completely inverted or not differentiated enough for colorblind people. This can lead to some bad time if people are not able to play with the colors they learned. A button to disable the block colors without disabling Chroma would be nice.

Chroma 2.0 gradients do not work on 1.18

Basically, the title. The Chroma 2.0 gradient now results in a simple "on" event.
I hope that can be fixed...

Steps to replicate:

  1. Launch 1.18
  2. Install Chroma with Heck and CustomJSONData
  3. Watch any lightshow that uses Chroma 2.0 gradients
  4. Enjoy your nothingness

Can't hit blocks on (most/some) Noodle Maps

I installed the newest Version of Chroma, Noodle and Heck and I tried some maps out to test all functionalities.

One worked fine, however on all other maps I tested I wasn't able to hit the blocks correctly. I think the offset breaks because now and then I got a hit but almost all were misses.

I disabled Chroma and tried the same maps again and then everything worked as intended.

(Tested maps: 14171 [only worked without chroma] ; 17e36 [Working with chroma] ; 11cf8 [only worked without chroma])

Here's a video of the issue: https://youtu.be/A-8wKtP8wOo

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.