aeiouenigma / sodium-forge Goto Github PK

Expected Behavior

Cactuses should look like this

Actual Behavior

Cactuses look like this

Reproduction Steps

1. Find a naturally generated dynamic cactus with sodium installed

System Information

• Java Version: 11 hotspot
• CPU: AMD Ryzen 3 1300X Quad-Core Processor
• GPU: Radeon RX 560 Series

Expected Behavior

the game to launch properly

Actual Behavior

it crashes on startup

Reproduction Steps

1. Launch the game with Better Foliage, Kotlin for Forge and Sodium installed.

Crash Report File

GitHub Gist

System Information

In the crash report file.

Additional Information

I tested this with Chlorine and Pannoniae's Sodium fork and it crashed as well.

Sodium overwrites the ItemRenderer.renderQuads method, and Quark injects into this method. This conflict results in a crash when using Quark's framed glass in a new world.

I don't fully understand how sodium's code works in this regard (despite maintaining the port), but until a proper solution is figured out I'm just keeping the sodium implementation disabled.

Expected Behavior

teleport to someone in another dimension

Actual Behavior

crash

System Information

---- Minecraft Crash Report ----
// There are four lights!

Time: 21-8-19 下午1:31
Description: Unexpected error

java.util.concurrent.CompletionException: java.lang.NullPointerException
at java.util.concurrent.CompletableFuture.reportJoin(Unknown Source) ~[?:1.8.0_291] {}
at java.util.concurrent.CompletableFuture.join(Unknown Source) ~[?:1.8.0_291] {}
at me.jellysquid.mods.sodium.common.util.collections.FutureDequeDrain.next(FutureDequeDrain.java:21) ~[sodium:0.2.0+rev.1] {re:classloading}
at me.jellysquid.mods.sodium.client.render.chunk.backends.multidraw.MultidrawChunkRenderBackend.setupUploadBatches(MultidrawChunkRenderBackend.java:231) ~[sodium:0.2.0+rev.1] {re:classloading}
at me.jellysquid.mods.sodium.client.render.chunk.backends.multidraw.MultidrawChunkRenderBackend.upload(MultidrawChunkRenderBackend.java:111) ~[sodium:0.2.0+rev.1] {re:classloading}
at me.jellysquid.mods.sodium.client.render.chunk.ChunkRenderManager.updateChunks(ChunkRenderManager.java:453) ~[sodium:0.2.0+rev.1] {re:classloading}
at me.jellysquid.mods.sodium.client.render.SodiumWorldRenderer.updateChunks(SodiumWorldRenderer.java:210) ~[sodium:0.2.0+rev.1] {re:mixin,re:classloading}
at net.minecraft.client.renderer.WorldRenderer.func_228437_a_(WorldRenderer.java:4763) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.WorldRenderer.func_228426_a_(WorldRenderer.java:936) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.GameRenderer.func_228378_a_(GameRenderer.java:608) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:astralsorcery:reach_set_client_renderer,pl:mixin:APP:sodium.mixins.json:core.matrix.MixinGameRenderer,pl:mixin:APP:flywheel.mixins.json:StoreProjectionMatrixMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:425) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:astralsorcery:reach_set_client_renderer,pl:mixin:APP:sodium.mixins.json:core.matrix.MixinGameRenderer,pl:mixin:APP:flywheel.mixins.json:StoreProjectionMatrixMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:976) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:customskinloader:MinecraftTransformer,pl:mixin:APP:sodium.mixins.json:features.options.MixinMinecraftClient,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:customskinloader:MinecraftTransformer,pl:mixin:APP:sodium.mixins.json:features.options.MixinMinecraftClient,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:184) ~[1.16.5.jar:?] {re:classloading,re:mixin,pl:runtimedistcleaner:A,pl:mixin:A,pl:runtimedistcleaner:A}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_291] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_291] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_291] {}
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_291] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.2.2.jar:36.2] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {}
Caused by: java.lang.NullPointerException
at mekanism.common.block.BlockBounding.func_220053_a(BlockBounding.java:281) ~[mekanism:10.0.21] {re:classloading}
at net.minecraft.block.AbstractBlock$AbstractBlockState.func_215700_a(AbstractBlock.java:537) ~[?:?] {re:mixin,re:classloading,pl:mixin:APP:immersiveengineering.mixins.json:coremods.AbstractBlockStateMixin,pl:mixin:A}
at net.minecraft.block.AbstractBlock$AbstractBlockState.func_196954_c(AbstractBlock.java:533) ~[?:?] {re:mixin,re:classloading,pl:mixin:APP:immersiveengineering.mixins.json:coremods.AbstractBlockStateMixin,pl:mixin:A}
at net.minecraft.block.AbstractBlock.func_196247_c(AbstractBlock.java:226) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
at net.minecraft.block.AbstractBlock$AbstractBlockState.func_235754_c_(AbstractBlock.java:427) ~[?:?] {re:mixin,re:classloading,pl:mixin:APP:immersiveengineering.mixins.json:coremods.AbstractBlockStateMixin,pl:mixin:A}
at net.minecraft.block.AbstractBlock$AbstractBlockState.func_200015_d(AbstractBlock.java:519) ~[?:?] {re:mixin,re:classloading,pl:mixin:APP:immersiveengineering.mixins.json:coremods.AbstractBlockStateMixin,pl:mixin:A}
at me.jellysquid.mods.sodium.client.render.chunk.tasks.ChunkRenderRebuildTask.performBuild(ChunkRenderRebuildTask.java:136) ~[sodium:0.2.0+rev.1] {re:classloading}
at me.jellysquid.mods.sodium.client.render.chunk.compile.ChunkBuilder$WorkerRunnable.run(ChunkBuilder.java:291) ~[sodium:0.2.0+rev.1] {re:classloading}
at java.lang.Thread.run(Unknown Source) ~[?:1.8.0_291] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Render thread
Stacktrace:
at java.util.concurrent.CompletableFuture.reportJoin(Unknown Source) ~[?:1.8.0_291] {}
at java.util.concurrent.CompletableFuture.join(Unknown Source) ~[?:1.8.0_291] {}
at me.jellysquid.mods.sodium.common.util.collections.FutureDequeDrain.next(FutureDequeDrain.java:21) ~[sodium:0.2.0+rev.1] {re:classloading}
at me.jellysquid.mods.sodium.client.render.chunk.backends.multidraw.MultidrawChunkRenderBackend.setupUploadBatches(MultidrawChunkRenderBackend.java:231) ~[sodium:0.2.0+rev.1] {re:classloading}
at me.jellysquid.mods.sodium.client.render.chunk.backends.multidraw.MultidrawChunkRenderBackend.upload(MultidrawChunkRenderBackend.java:111) ~[sodium:0.2.0+rev.1] {re:classloading}
at me.jellysquid.mods.sodium.client.render.chunk.ChunkRenderManager.updateChunks(ChunkRenderManager.java:453) ~[sodium:0.2.0+rev.1] {re:classloading}
at me.jellysquid.mods.sodium.client.render.SodiumWorldRenderer.updateChunks(SodiumWorldRenderer.java:210) ~[sodium:0.2.0+rev.1] {re:mixin,re:classloading}
at net.minecraft.client.renderer.WorldRenderer.func_228437_a_(WorldRenderer.java:4763) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.WorldRenderer.func_228426_a_(WorldRenderer.java:936) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.GameRenderer.func_228378_a_(GameRenderer.java:608) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:astralsorcery:reach_set_client_renderer,pl:mixin:APP:sodium.mixins.json:core.matrix.MixinGameRenderer,pl:mixin:APP:flywheel.mixins.json:StoreProjectionMatrixMixin,pl:mixin:A,pl:runtimedistcleaner:A}
-- Affected level --
Details:
All players: 4 total; [ClientPlayerEntity['Cold_Tears_YY'/375182, l='ClientLevel', x=-340.78, y=76.00, z=898.30], RemoteClientPlayerEntity['BinGe'/365254, l='ClientLevel', x=-338.31, y=65.94, z=893.60], RemoteClientPlayerEntity['Jianmianqishi'/341990, l='ClientLevel', x=-340.78, y=76.00, z=898.30], RemoteClientPlayerEntity['xuanche243'/164347, l='ClientLevel', x=-304.30, y=53.00, z=893.30]]
Chunk stats: Client Chunk Cache: 1024, 806
Level dimension: minecraft:overworld
Level spawn location: World: (987,85,601), Chunk: (at 11,5,9 in 61,37; contains blocks 976,0,592 to 991,255,607), Region: (1,1; contains chunks 32,32 to 63,63, blocks 512,0,512 to 1023,255,1023)
Level time: 3173695 game time, 3592035 day time
Server brand: forge arclight
Server type: Non-integrated multiplayer server
Stacktrace:
at net.minecraft.client.world.ClientWorld.func_72914_a(ClientWorld.java:447) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:astralsorcery:sun_brightness_client,xf:fml:xaerobetterpvp:xaero_clientworldclass,pl:mixin:APP:sodium.mixins.json:features.chunk_rendering.MixinClientWorld,pl:mixin:APP:sodium.mixins.json:features.world_ticking.MixinClientWorld,pl:mixin:APP:create.mixins.json:BreakProgressMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_71396_d(Minecraft.java:2029) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:customskinloader:MinecraftTransformer,pl:mixin:APP:sodium.mixins.json:features.options.MixinMinecraftClient,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:628) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:customskinloader:MinecraftTransformer,pl:mixin:APP:sodium.mixins.json:features.options.MixinMinecraftClient,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:184) ~[1.16.5.jar:?] {re:classloading,re:mixin,pl:runtimedistcleaner:A,pl:mixin:A,pl:runtimedistcleaner:A}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_291] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_291] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_291] {}
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_291] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.2.2.jar:36.2] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {}

-- System Details --
Details:
Minecraft Version: 1.16.5
Minecraft Version ID: 1.16.5
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_291, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 2140583320 bytes (2041 MB) / 3858759680 bytes (3680 MB) up to 4294967296 bytes (4096 MB)
CPUs: 16
JVM Flags: 12 total; -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=16M -XX:-UseAdaptiveSizePolicy -XX:-OmitStackTraceInFastThrow -Xmn128m -Xmx4096m -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -XX:+IgnoreUnrecognizedVMOptions
ModLauncher: 8.0.9+86+master.3cf110c
ModLauncher launch target: fmlclient
ModLauncher naming: srg
ModLauncher services:
/mixin-0.8.2.jar mixin PLUGINSERVICE
/eventbus-4.0.0.jar eventbus PLUGINSERVICE
/forge-1.16.5-36.2.2.jar object_holder_definalize PLUGINSERVICE
/forge-1.16.5-36.2.2.jar runtime_enum_extender PLUGINSERVICE
/accesstransformers-3.0.1.jar accesstransformer PLUGINSERVICE
/forge-1.16.5-36.2.2.jar capability_inject_definalize PLUGINSERVICE
/forge-1.16.5-36.2.2.jar runtimedistcleaner PLUGINSERVICE
/mixin-0.8.2.jar mixin TRANSFORMATIONSERVICE
/forge-1.16.5-36.2.2.jar fml TRANSFORMATIONSERVICE
FML: 36.2
Forge: net.minecraftforge:36.2.2
FML Language Providers:
[email protected]
minecraft@1

When i launch the game it crashes with the exit code 1

Reproduction Steps

Start up with both Lucent and Soidum

Crash Report File

crash-2021-08-10_14.39.11-client.txt

Additional Information

Provide any additional information or context which may be relevant to the issue. If you have none to add, you can remove this section.

Expected Behavior

Snow layer and plant should both render

Actual Behavior

Only the snow layer renders

Reproduction Steps

Provide information on how to reproduce this game crash. You can either fill in the example below or do something else -- just make sure your instructions are minimal and clear! If applicable, please provide a world file as a compressed ZIP which contains a minimally reproducible example of the issue.

1. Install SnowRealMagic and Sodium
2. Make snow layer fall onto a flower
3. Observe flower

Attachments

System Information

• Java Version: 8
• CPU: Intel Core i5-8400
• GPU: NVIDIA GTX 1060

TODO: Fill in this issue with actual details

Expected Behavior

Items like buzzier bees's bug bottles should be animated.

Actual Behavior

They arne't animated.

Reproduction Steps

1. Log in i guess
2. Acquire a bottle of bee /give @p buzzier_bees:bee_bottle or whatever the code for bee bottles are?
3. See that they are not animated

This happened on all three different computers i tried this on, one windows and two macs, so i don't think it's a problem with my computer.

Reproduction Steps

1. Flying around the world in creative.

Crash Report File

https://gist.github.com/Andrxia/2ee87fe52c75ac9ebcd204bd815f31cf

Additional Information

I can't figure out what is causing this.. all it shows is smth about sodium. Also new to GitHub so apologies if my report isnt very clear. When I walk around slowly around the world nothing crashes, but when I fly to explore more chunks it crashes. I've tried multiple worlds but this still continues to happen.

Would it be possible for Iris shaders to be implemented? It would be great to have Sodium levels of performance combined with shaders.

Link to Iris: https://github.com/IrisShaders/Iris

This is a known issue in Sodium (Fabric). When a fix is committed to their repository, I will look into merging it here.

The game crashes when entering a world with latest FTB Chunks with latest sodium froge

Reproduction steps:

1. Enter a world
2. The game crashes

Crash log:
crash-2021-08-07_13.25.34-client.txt

Expected Behavior

chunks should be loading fine and not having chunks missing and should also water should not be invisible

Actual Behavior

chunks should be loading normally but they are being funky and bits of them don't load and I can x-ray through them and also water is invisible, some water isn't invisible tho its weird

Reproduction Steps

literally just entering the game

Attachments

https://cdn.discordapp.com/attachments/824503477823864832/839196225126793267/2021-05-04_18.45.43.png

System Information

You can obtain this information from the in-game debug screen or through using DxDiag on Windows. (wtf)

• Java Version: [I have no idea how to check]
• CPU: [same thing]
• GPU: [same again]

Expected Behavior

Mekanism Cables Render Correctly

Actual Behavior

Reproduction Steps

Install Mekanism, install sodium-forge, and place mekanism cables in different directions

Quark glass item frames does not render

Expected Behavior

I expected Chisels and Bits blocks to render like they do without sodium-forge.

Actual Behavior

Rendering is extremely broken, not even resembling a block.

Reproduction Steps

1. Load a world with a block from Chisels & Bits

Attachments

System Information

You can obtain this information from the in-game debug screen or through using DxDiag on Windows.

• Java Version: 16.0.1
• CPU: AMD Ryzen Threadripper 1920X 12-Core Processor
• GPU: GeForce RTX 3060 Ti

This is a known issue in Sodium (Fabric). When a fix is committed to their repository, I will look into merging it here.