ae9rb / ruby-redis Goto Github PK

Time complexity in zset.rb can be made to match the C version. All other data types should already match.

There aren't tests to ensure every command triggers watched keys in a transaction. Anything that sets a database key is covered. Deeper changes, like adding a member to a hash, aren't caught automatically. Review the code and add touch calls where needed.

One of my major problems with redis-rb was it's total lack of documentation, which made it difficult to determine what Object types would be returned/yielded from various methods. It would be totally rad if ruby-redis had full YARD documentation with @param, @yield, @return and @raise tags.

Perhaps INFO "redis_version" should be the redis version this lib is inline with, for applications that use this to verify the running version meets requirements.

Current:

-> % redis-cli
redis 127.0.0.1:6379> info
redis_version:0.0.2
redis_git_sha1:Ruby
redis_git_dirty:1

don't write a database server in ruby wtf