Git Product home page Git Product logo

Comments (3)

adzialocha avatar adzialocha commented on July 17, 2024 1

Correction - bundle = new OSC.Bundle(Date.now() + 5000, message) has the right timestamp, but the message doesn't get added.
The PR fixes bundle = new OSC.Bundle([message], Date.now() + 5000), in any case.

Amazing! Thanks for spotting this @yaxu! Another reason to slowly look into porting this project to Typescript 😅

from osc-js.

yaxu avatar yaxu commented on July 17, 2024

I think I found the bug:

osc-js/src/bundle.js

Line 55 in d5693c6

if (args.length > 1 && (args[1] instanceof Date || isInt(args[0]))) {

isInt(args[0]) should be isInt(args[1]).

Currently:

  • this doesn't work: bundle = new OSC.Bundle([message], Date.now() + 5000)
  • this does: bundle = new OSC.Bundle(Date.now() + 5000, message)

from osc-js.

yaxu avatar yaxu commented on July 17, 2024

Correction - bundle = new OSC.Bundle(Date.now() + 5000, message) has the right timestamp, but the message doesn't get added.
The PR fixes bundle = new OSC.Bundle([message], Date.now() + 5000), in any case.

from osc-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.