Git Product home page Git Product logo

Comments (12)

mohlek avatar mohlek commented on June 16, 2024

removing allowEmpty from global config doesnt fix the formating..
Passing 'DD.MM.YYYY' in the hbs works. So it just dont read from global config anymore

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

I don't think they're related, I rewrote a large chunk and might have introduced something

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

what version of ember?

from ember-moment.

mohlek avatar mohlek commented on June 16, 2024

sadly 1.13.8 due to deprecation stuff ...

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

That's fine, that's actually ideal right now since it's using Ember.Helper. I'll work on fixing it now.

from ember-moment.

mohlek avatar mohlek commented on June 16, 2024

Another thing I discovered is when passing a null date.
the readme says If null, undefined, or an empty string as a date to any of the moment helpers then you you will Invalid Date in the output. To avoid this issue globally, you can set the option allowEmpty which all of the helpers respect and will result in nothing being rendered instead of Invalid Date.

In fact it renders the current date.

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

Another thing I discovered is when passing a null date.

I can't reproduce this one

from ember-moment.

mohlek avatar mohlek commented on June 16, 2024

Hm .. Might be an other interesting thing in the ember universe :)
But since I can set allowEmpty it doesnt kill me anymore.

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

3.6.1 released

If you can show me an example of the null rendering the current date I'd like to try and see what is going on there but tried it on all the helpers and I'm seeing Invalid Date as expected when allowEmpty is false in the global config

from ember-moment.

mohlek avatar mohlek commented on June 16, 2024

I cant provide an example since my project is from my company and this would break some copyright shit and so on :-/
But i can tell you the way I go :)

I am using ember data to get, as you expect, data from my api.
if a date is not set my api wont return the field. So the field should be null / unset.

my global config looks like above, without allowEmpty. And so the hbs.

I will try to get an example with mirage running later at home.

//edit
Now that the global format is working again it will produce 19.08.2015 for me.

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

If you can isolate the issue and shoot me an example that would be awesome. I don't use ember-data much these days and would probably spin my wheels trying to reproduce it.

What I think is happening is the thing you think is null is not null. You can log the prop using the {{log propKey}} helper

from ember-moment.

mohlek avatar mohlek commented on June 16, 2024

Nice i didn't knew the {{log}}. I'm quiet new to ember ^^

{{log model.someDate}} produces:

Wed Jun 26 2013 00:00:00 GMT+0200 (Westeuropäische Sommerzeit)
Mon Jun 10 2013 00:00:00 GMT+0200 (Westeuropäische Sommerzeit)
3x undefined

The 3 undefined "dates" are the one which will produce the current date.
I will try to setup an empty reproducing project and leave you a message.

Thanks so far.

from ember-moment.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.