Git Product home page Git Product logo

Comments (8)

schorke avatar schorke commented on June 25, 2024

@aoumiri I don't understand why this error exists (we encountered the same error) while Ember.computed.bool is only deprecated in Ember 3.27.0 and should stay deprecated until Ember 4.0.0 , so it should not cause an error...

Did I miss something or am I completely dumb ?

from ember-moment.

timmyomahony avatar timmyomahony commented on June 25, 2024

I'm encountering this with ember-moment 8.0.1 on ember-source 3.28.0 running the following in a template:

{{moment-format (now) 'YYYY'}}

Throws the error:

Uncaught TypeError: Ember.computed.bool is not a function
    at Module.callback (-base.js:10)
    at Module.exports (loader.js:106)
    at Module._reify (loader.js:143)
    at Module.reify (loader.js:130)
    at Module.exports (loader.js:104)
    at Module._reify (loader.js:143)
    at Module.reify (loader.js:130)
    at Module.exports (loader.js:104)
    at requireModule (loader.js:27)
    at Class._extractDefaultExport (index.js:462)

Which seems to relate to here:

https://github.com/stefanpenner/ember-moment/blob/382ddd1238c7bcab2f66225830d18aca5364c2f6/addon/helpers/-base.js#L9

from ember-moment.

timmyomahony avatar timmyomahony commented on June 25, 2024

Just to note, the PR from here fixes this for me:

#351

You can get it with:

yarn add stefanpenner/ember-moment#351/head

from ember-moment.

aoumiri avatar aoumiri commented on June 25, 2024

@jasonmit @stefanpenner can anyone of you have a look at this PR? Or any maintainer 🙏

Thanks 😊

from ember-moment.

robclancy avatar robclancy commented on June 25, 2024

Isn't this an ember bug? I am getting these same errors from app code when it was just meant to be a deprecation.

from ember-moment.

aoumiri avatar aoumiri commented on June 25, 2024

Ember bug or not, I think it's still worth fixing now if it will be deprecated. Rather than waiting for the next major. WDYT ?

from ember-moment.

esbanarango avatar esbanarango commented on June 25, 2024

#351 (comment)

from ember-moment.

NullVoxPopuli avatar NullVoxPopuli commented on June 25, 2024

Fix released in 8.0.2

from ember-moment.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.