Comments (6)
There is a bug in ember around parameterless helpers. Once that is resolved I can look into adding this.
from ember-moment.
+1, what's your thoughts on a global config like this? it can default to false, I can make a PR if wanted
// addon/utils/compute-fn.js
import Ember from 'ember';
import config from '../config/environment';
export default function(cb) {
return function(params, hash) {
if (!params || params && params.length === 0) {
throw new TypeError('ember-moment: Invalid Number of arguments, expected at least 1');
}
let allowEmpty = Ember.get(config, 'moment.allowEmpty');
const datetime = params[0];
if(hash.allowEmpty || hash['allow-empty'])
{
allowEmpty = hash.allowEmpty || hash['allow-empty'];
}
if ([null, '', undefined].indexOf(datetime) > -1 && allowEmpty) {
Ember.Logger.warn('ember-moment: an empty value (null, undefined, or "") was passed to moment-format');
return;
}
return cb.apply(this, arguments);
};
}
// config.environment.js
module.exports = function() {
return {
moment: {
allowEmpty: true
}
}
};
from ember-moment.
That seems interesting, I'm in favor and would be happy to review your PR. My original interpretation was the OP wanted to just write {{moment-format}} without ever passing an argument. Makes sense to make allow-empty a global setting.
from ember-moment.
@jasonmit well, at least I want to pass a date :) Even though its null..
@jcope2013 that fix seems to do just what i wanted :) Please PR
from ember-moment.
Thanks @jcope2013
I have some house keeping changes and will version tomorrow.
from ember-moment.
3.6.0 closes this. Thanks again everyone
from ember-moment.
Related Issues (20)
- Timezone doesn't apply HOT 3
- [ember-moment] attempted to set timezone, but moment-timezone is not setup. HOT 2
- "Invalid date" in Safari HOT 1
- Using ember-moment in Ember 3.18 fails to produce production build HOT 8
- When calling `deprecate` you must provide `for` in options. Missing options.for in "ember-moment.addon.helpers.moment-to-now" deprecation
- Import `computed.bool` from the right package HOT 8
- error starting ember with ember-moment HOT 1
- Ember Global deprecation warning due to old version of ember-cli-babel
- `services/moment.js` bug in `defaultFormat` HOT 3
- moment-timezone dependency added HOT 5
- toggling locales does not take effect
- Is ember-cli-moment-shim still required for ember-moment? HOT 3
- Timezone not accesible after upgrading to version 9 HOT 2
- Environment configuration does not work as documented HOT 2
- Update dependency `@embroider/addon-shim` to `^1.0.0`
- Display an optional message when date is null/invalid/undefined
- Documentation incorrect for environment settings
- ember-moment is trying to import from ember-cli-moment-shim but that is not one of its explicit dependencies Error thrown while using Embroider compat build HOT 15
- Error importing moment-timezone with ember-auto-import 2.6.2 HOT 3
- Error: Could not find module `moment` imported from `(require)` on Ember 4.12 during embroider-safe scenario HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-moment.