Git Product home page Git Product logo

Comments (11)

jasonmit avatar jasonmit commented on June 16, 2024

What version of moment is being pulled in?

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

Also what version of ember cli and did you install ember-moment through ember install or npm install.

from ember-moment.

mydea avatar mydea commented on June 16, 2024

I'm using the newest versions as far as I've seen:

  • ember-cli 1.13.8
  • ember-moment-shim 0.6.1
  • ember-moment 3.5.1
  • ember 1.13.8
  • moment 2.10.6
  • moment-timezone 0.4.0

I installed it via ember install.

(I tried it with the included moment-version 2.8.0 and with the newest 2.10.6)

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

I haven't been able to reproduce this, any chance you can isolate it to an example and push it to github? Will help speed up patch time

from ember-moment.

mydea avatar mydea commented on June 16, 2024

I have this issue with this pretty minimal example:

https://github.com/mydea/ember-cli-example-app-for-github/tree/ember-moment

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

I'm not seeing the error, perhaps its an issue with your npm packaging cache?

ember-cli-example-app-for-github git:master ❯ ember s                                                                                                                    
version: 1.13.8
Livereload server on http://localhost:49152
Serving on http://localhost:4200/

Build successful - 3604ms.

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
Concat: Vendor                                | 2282ms              

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
Concat: Vendor (1)                            | 2282ms              
Babel (6)                                     | 421ms (70 ms)       
Funnel (43)                                   | 191ms (4 ms)  

from ember-moment.

mydea avatar mydea commented on June 16, 2024

I deleted the tmp, node_modules and bower_components folder, ran the following commands:

npm cache clean
bower cache clean
npm install
bower install
ember g ember-moment

and it still threw the same error.

from ember-moment.

redpist avatar redpist commented on June 16, 2024

Hi.
It seems to be an error in ember-cli-moment-shim (a major dependency of ember-moment).
Files related to the included locales are directly imported from the moment 'locales' folder:
https://github.com/jasonmit/ember-cli-moment-shim/blob/d2e4f5205979b681f7118d31f50543fc16dd9c68/index.js#L42
but the 'en' locale is "almost-hardcoded" in moment.js and not present in the locale folder :
https://github.com/moment/moment/tree/develop/locale
To bypass this problem, you can omit the 'en' locale in includeLocales.

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

It seems to be an error in ember-cli-moment-shim

I don't see where I'm including en though. I can warn on mismatches but that's the best I can do. The documentation points to the list of available locales.

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

jasonmit/ember-cli-moment-shim#17 will warn on mistmatches now and quietly ignore if you pass en since it's included by default. Will version shim as 0.6.2 and bump ember-moment dep as well and version

from ember-moment.

jasonmit avatar jasonmit commented on June 16, 2024

3.6.2 fixes this, be sure you update your apps ember-cli-moment-shim dep to 0.6.2 or rerun the blueprint.

from ember-moment.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.