issue testing page with moment-from-now about ember-moment HOT 9 CLOSED

Ember.run.cancel to cancel anything outstanding on the run loop queue. It's something you want to get into the habit with testing.

from ember-moment.

@jasonmit Perhaps I misunderstood you, or you misunderstood me...
the testing code looks like this:

test: function() {
   visit("/pending-users");
   andThen(function() {
      assert(...page contains what is expected...);
   }
}

Where would I place the cancel? The only place that makes sense is between the visit to the andThen.
What timer should I pass to the cancel? it accepts a parameter, but there is no way to know the runlater timer set by ember-moment.
Attempting to use instead the (private) method Ember.run.cancelTimers() failed even more tests... I did not debug exactly why.

from ember-moment.

@Iftahh sorry, I do think I misunderstood. Is your project public so I can step through this?

@stefanpenner have anything better in mind than replacing the Ember.run.later with setTimeout + Ember.run?

https://github.com/stefanpenner/ember-moment/blob/master/addon/helpers/moment-from-now.js#L12

from ember-moment.

@jasonmit seems like the timer should be canceled in destroy() of that helper

from ember-moment.

👍 will fix shortly

from ember-moment.

that wont help the above issue, as the timerwaiters in the test helpers are not granular enough.

The solution in ember will land shortly have async/await is supported in jshint, which will revamp the test helpers. Long story, upside @teddyzeenny and myself spike it was ember conf, it was wonderful and glorious but was blocked on tooling (just jshint) support, and stage 2 TC39 support.

In the interim: you should work-around this, by doing both: #80 (comment)

and the suggested raw setTimeout + Ember.run trick, which wont insert a test waiter, like run.later will.

from ember-moment.

Thank you @jasonmit and @stefanpenner for your quick responses and fix !

@jasonmit my code isn't open source but you should be able to reproduce it very easily -
use ember cli to generate acceptance-test and visit a page containing moment-from-now helper somewhere in the template - that should be enough.

from ember-moment.

3.5.1 published, take it for a spin and report if this issue persists.

P.S., I only fixed this because of your avatar photo.

from ember-moment.

Thanks @jasonmit

from ember-moment.