legacy-register initializer is incorrectly added to Ember 2.0.1 addon about ember-moment HOT 6 CLOSED

I should point out that, for the record, I am seeing this problem both in an ember-cli application running Ember 2.0.1 and an ember-cli addon running Ember 2.0.1. It was easier to create the minimal reproduction case based on the addon, so I did that.

If there's anything else I can do that would be helpful (or if there are any pointers that would help in debugging this), please let me know. I've already spent a lot of time digging around inside the broccoli trees, and I don't mind spending more if it will help get the problem solved.

Thanks!

from ember-moment.

It appears included isn't being invoked twice but the addon tree is invoked twice. (which itself is dubious).

Taking a look..

from ember-moment.

A quick fix would be for this check to be inverted, rather make the legacy the opt in, rather then opt out.

The root issue appears to be multiple paths to initializing addons due to how the legacy registry worked...

from ember-moment.

I am fine at this point dropping legacy support and versioning accordingly. Thoughts Stefan?

from ember-moment.

I am fine at this point dropping legacy support and versioning accordingly. Thoughts Stefan?

👍

from ember-moment.

Versioned as 4.0.0 and also will resolve this issue.

from ember-moment.