adonisjs / repl Goto Github PK

Hey! 👋

I'm the maintainer of parse-imports. I'm going to publish v1.0.0 soon and migrate to ESM-only (i.e. "type": "module") without publishing a CJS version of the package.

I noticed that your package accounts for most usage of parse-imports, but also that it does not specify "type": "module", so you would encounter some issues if you try to upgrade. You have a few options:

1. Not upgrading to v1.0.0
2. Upgrading to v1.0.0, still targeting CJS, and using dynamic import to import parse-imports instead of require (you can't require ESM modules)
3. Upgrading to v1.0.0 and targeting ESM (in this scenario you can import parse-imports normally)

I would recommend eventually getting to 3 because that's the direction the ecosystem is moving.

Anyways, just thought I'd give you a heads up! Feel free to close this issue after you read it

The current implementation of the REPL server does not permit alterations to the default prompt or redirection of input and output, as observed in the existing codebase:

To enhance flexibility and user control, I propose the introduction of a functionality that allows users to override the options supplied to the Node.js startRepl method. The proposed change is illustrated below:

  start(options) {
    console.log('')
    this.notify('Type ".ls" to a view list of available context methods/properties')

    this.server = startRepl({
      prompt: `> ${this.#compiler?.supportsTypescript ? '(ts) ' : '(js) '}`,
      input: process.stdin,
      output: process.stdout,
      terminal: process.stdout.isTTY && !Number.parseInt(process.env.NODE_NO_READLINE!, 10),
      useGlobal: true,
      ...options,
    })

This modification would grant users greater control over the REPL environment. Thanks!