Model `save` function does not return the model anymore about attachment-lite HOT 8 CLOSED

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from attachment-lite.

Closing in favor of the PR.

from attachment-lite.

@thetutlage I am facing the same issue? Any fix or workaround?

from attachment-lite.

@hbatalhaStch the workaround would be to just treat the save function as if it is not returning anything.

So instead of chaining model.save().otherMethod(); use model.save(); model.otherMethod();.
Or instead of returning return model.save() use model.save(); return model;

from attachment-lite.

@aa-ndrej thanks for the tip.

I have a question though: I am using the return of model.save() to check if save was successful, is this a good way? Is there a need to check if save was successful?

from attachment-lite.

@hbatalhaStch you can view the source code of the models save function if you navigate to node_modules/@adonisjs/lucid/build/src/Orm/BaseModel/index.js. I do not have that much experience with adonisjs but as far as I can see the function just returns return this;, so it is not really indicating that the model was successfully saved.
But I would assume that the save function would throw some kind of error otherwise.

from attachment-lite.

@aa-ndrej

you can view the source code of the models save function...

I already cloned the lucid repo to study to see if it throws somewhere

but as far as I can see the function just returns return this;

I am trying to see if any of the functions called above throws an error
@thetutlage would be helpful here.

Thanks

from attachment-lite.

Released as 1.0.8

from attachment-lite.