Pre compute on demand not work about attachment-lite HOT 7 CLOSED

This should not be closed, this was very confusing.

Based on this section of the docs
https://github.com/adonisjs/attachment-lite#pre-compute-on-demand

Having to replicate the options of the decorator with preComputeUrls set to true is not ideal.

I would consider adding another function meant for computing on demand where a forced flag or something can be passed to computeUrl so it ignores the value of preComputerUrls.

I can provide a patch if that sounds like an acceptable approach.

from attachment-lite.

Looking for test file, you use setOptions method:

If i set this on preCompute on demand methos, it works:

class User extends BaseModel {
  public static async preComputeUrls(models: User | User[]) {
    if (Array.isArray(models)) {
      await Promise.all(models.map((model) => this.preComputeUrls(model)))
      return
    }

    models.avatar?.setOptions({ disk: 'diskName', preComputeUrl: true }) // Only work if i replicate options of model, including preComputeUrl
    await models.avatar?.computeUrl()
    await models.coverImage?.computeUrl()
  }
}

from attachment-lite.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from attachment-lite.

So far I am not sure what exactly this issue is about. Is it that preComputeUrl option not functioning as documented or something else?

from attachment-lite.

So following the docs it's recommened to not set preComputeUrls to true on the decorator.

class User extends BaseModel {
  @attachment({ preComputeUrl: false})
  public avatar: AttachmentContract
}

class User extends BaseModel {
  public static async preComputeUrls(models: User | User[]) {
    if (Array.isArray(models)) {
      await Promise.all(models.map((model) => this.preComputeUrls(model)))
      return
    }

    await models.avatar?.computeUrl()
    await models.coverImage?.computeUrl()
  }
}

This function does not work as described. computeUrl always returns early if preComputeUrl is false or undefined. No URL's are computed.

I do not think this is a documentation issue, I would expect computeUrl to always build the urls and having preComputeUrls on the decorator to false/undefined shouldn't affect running the function on demand.

from attachment-lite.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from attachment-lite.

not stale

from attachment-lite.