Failed to send the request: Upload Id not found in create-multipart-upload response about s3mock HOT 9 CLOSED

Yes, I am going to do it right now, thanks!

from s3mock.

@campidelli not sure what goes wrong with your code.
I added an integration test that uses the CRT client, and it works just fine, see linked PR...

from s3mock.

there are two ways to add the CRT client to the S3AsyncClient - see S3TestBase.kt. It's in Kotlin, but the syntax is not too different from Java.
Not sure why, but I can't get one of the CRT clients to work with an https endpoint.
The test works with both of them.

Only the "autoCrt" client (using your way to set it up) lands in this method though:

		at software.amazon.awssdk.services.s3.internal.crt.S3CrtResponseHandlerAdapter.onFinished(S3CrtResponseHandlerAdapter.java:93) ~[s3-2.20.78.jar:na]

from s3mock.

is this the service you're working on?

https://github.com/campidelli/file-storage-service/blob/main/pom.xml#L92
The CRT dependency is included in the regular V2 SDK - you should use the same version coming from the AWS BOM POM you imported:

<dependency>
      <groupId>software.amazon.awssdk</groupId>
      <artifactId>aws-crt-client</artifactId>
    </dependency>

from s3mock.

Hi @afranken, thanks for the prompt response.

I have followed this tutorial (https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/transfer-manager.html) where they ask for this specific version or higher, I didn't know the client was part of the SDK already, good catch!

The project I am working on is similar to this, but it is an internal one.

If I change the Client to use the HTTP version, I lose the multipart upload feature< I quote from https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/crt-based-s3-client.html

Although both components use libraries from the AWS Common Runtime, the AWS CRT-based S3 client uses the aws-c-s3 library and supports the S3 multipart upload API features. Since the AWS CRT-based HTTP client is meant for general purpose use, it does not support the S3 multipart upload API features.

from s3mock.

For this specific test I am using the putObject API, as you can check on the following code (from my REST controller):

    @PostMapping
    public Mono<ResponseEntity<UploadResult>> uploadHandler(@RequestHeader HttpHeaders headers, @RequestBody Flux<ByteBuffer> body) {

        long length = headers.getContentLength();
        if (length < 0) {
            throw new UploadFailedException(HttpStatus.BAD_REQUEST.value(), Optional.of("required header missing: Content-Length"));
        }

        String fileKey = UUID.randomUUID().toString();
        Map<String, String> metadata = new HashMap<>();
        metadata.put("file_name", "test");
        MediaType mediaType = headers.getContentType();

        if (mediaType == null) {
            mediaType = MediaType.APPLICATION_OCTET_STREAM;
        }

        log.info("UploadHandler: mediaType {}, length={}, fileKey = {}", mediaType, length, fileKey);
        Mono<PutObjectResponse> putObjectResponseMono = Mono.fromFuture(s3client.putObject(PutObjectRequest.builder()
                        .bucket(s3config.getBuckets().upload())
                        .contentLength(length)
                        .key(fileKey)
                        .contentType(mediaType.toString())
                        .metadata(metadata)
                        .build(),
                AsyncRequestBody.fromPublisher(body)));

        return putObjectResponseMono
                .map((response) -> {
                    checkUploadResult(response);
                    return ResponseEntity
                            .status(HttpStatus.CREATED)
                            .body(new UploadResult(HttpStatus.CREATED, new String[]{fileKey}));
                });
    }

from s3mock.

Can you please include this in your test and see if it works?

Thanks!

from s3mock.

Just added a test, works without problems:
https://github.com/adobe/S3Mock/blob/main/integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/CrtAsyncV2IT.kt

must still be something with the way you set up the client, or the interaction with Spring reactive?
Maybe you could try to reproduce the problem in your example service...

from s3mock.

I have updated my project and the error doesn't happen anymore.
However, I am facing another issue, which is probably an implementation error, I would gladly accept a hand here.
#1182
Thanks!

from s3mock.