adobe / adobeio-cna-starter-project Goto Github PK

2 action build modes are supported for now:
a. in manifest.yml point to action file: Minifies action and action's dependencies using parcel
b. in manifest.yml point to the action's directory + package.json file in action's folder: Installs dependencies and zips the action

But if we point to an action file + have a package.json file in the folder, parcel installs unnecessary dev dependencies such as @babel/core which pollutes the action folder with a package-lock.json and node_modules/ and modifies the package.json file.

Expected Behaviour

Best: bundle action with parcel without polluting folder
Middle: don't bundle with parcel, create a zip action instead if there is a package.json file
at least: show an error

Actual Behaviour

Unnecessary installed dependencies in developer's action folder

Steps to Reproduce

• cd actions/hello
• npm init
• press enter to every question
• cd ../../
• npm run build:actions

Expected Behaviour

Deploy works

Actual Behaviour

Deploy fails

Steps to Reproduce

Create an action with a dependency on bwip-js, in scripts/build.actions.js verify that minify is set to true.

Sample Code that illustrates the problem

See https://github.com/icaraps/cna-barcode-generator/blob/master/actions/barcode/index.js

Logs taken while reproducing problem

 Returned HTTP 400 (Bad Request) --> 
 ›   "The request content was malformed:
 ›   Unexpected end-of-input at input index 1623 (line 1, position 1624), 
 ›   expected '"':

Currently we are just doing e2e testing in travis on local builds

Testing of deployment is missing, add a remote deployment command to travis and run an e2e test on it.

To solve this we probably need:

• support for remote target in e2e
• embedding of ow credentials into travis
• and then add deployment + remote e2e test to travis build

Steps to Reproduce

Write an action with a dependency on node-canvas to render a canvas.

Sample Code that illustrates the problem

See the example at https://github.com/Automattic/node-canvas

Logs taken while reproducing problem

TypeError: bindings.CanvasRenderingContext2dInit is not a function

Expected Behaviour

Deploy UI URL should point to the UI I am working on

Actual Behaviour

https://<namespace>.dev.adobe-runtime.com/adobeio-cna-starter-project-0.1.0/index.html
seems to be always pointing to deployment of cna-demo instead of owner's namespace s3 folder

This is misleading at first and creates CORS issues to access the backend
After making changes to the UI it is clear that the deployment URL is not pointing to the desired deployment

Reproduce Scenario (including but not limited to)

Use a different namespace than cna-demo

• do some changes in the UI
• deploy

The config file that is generated by the build should include text to make sure that users don't think they should modify it.

Relates to parcel-bundler/parcel#2581

Steps to Reproduce

1. npm install node-fetch
2. replace content actions/hello/index.js with

const fetch = require('node-fetch')
async function main (args) {
  try {
    const content = await fetch('https://jsonplaceholder.typicode.com/todos/1')
    return {
      body: await content.json()
    }
  } catch (e) {
    console.error(e)
    return {
      body: e.message
    }
  }
}
exports.main = main

3. (optional) In scripts/build.actions.js replace minify: true, with minify:false,
4. npm run build:actions && npm run deploy:actions
5. click on the action url
   you should see fetch is not a function

Note 1: node-fetch is exported as an es6 module
Note 2: The same action works fine if deployed as a zip action

Workaround

In the action replace const fetch = require('node-fetch') with const fetch = require('node-fetch').default

When running npm run dev and do some code changes for example in an action an additional chrome tab will be automatically opened pointing to http://localhost:9800.
This can be very annoying when multiple changes are done and saved.

Way better would be, do nothing and let the developer refresh the page.

When running the command
'npm run dev' I get the following error
'NODE_ENV' is not recognized as an internal or external command

Expected Behaviour

Start the local development server

Actual Behaviour

get the following error
'NODE_ENV' is not recognized as an internal or external command

Steps to Reproduce

Running 'npm run dev' on Windows command line

• Take the hello action from the CNA starter
• Change the manifest.yaml in following way so the ZIP build is executed from scripts/build.action.js

packages:
  __CNA_PACKAGE__:
    license: Apache-2.0
    actions:
      hello:
        function: actions/hello
        web: yes
        runtime: 'nodejs:10'

A ZIP is build, but the JavaScript is never compiled with npm.

Currently the starter project is using Mocha + Chai for unit tests.
Move the unit test setup to Jest, so that all CNA apps use the same testing tools

Expected Behaviour

Server side static files required by dependencies are uploaded

Actual Behaviour

Server side static files are not uploaded

Steps to Reproduce

See https://github.com/icaraps/cna-barcode-generator/blob/master/actions/barcode/index.js.
Set includetext to true.
Since the fonts are not uploaded, the includetext option won't work.

Same issue as described here metafloor/bwip-js#118

Documentation:

New comers miss the information on how to acquire the I/O Runtime / OpenWhisk credentials which are needed to use the starter.

We should add this to the README

Currently every commit/pr triggers an end to end build, which includes installing google chrome. It's 54MB and our tests on windows are taking 8-10 minutes.

Behaviour

It seems that aio runtime truncates the code and this results in a malformed request error

✖ Deploy actions
 ›   Error: Command failed: aio runtime deploy -m /Users/mraho/work/adobeio-cna-starter-project/.manifest-dist.yml
 ›     ›   Error: Failed to deploy: the request content was malformed:
 ›     ›   unexpected end-of-input at input index 74845 (line 1, position 74846),
 ›     ›   expected '"':

This also doesn't work with wskdeploy -m .manifest-dist.yml and wsk action create myaction dist/actions/hello.js

Steps to Reproduce

• $ npm install @adobe/aio-cli-config
• add const config = require('@adobe/aio-cli-config') to the top of actions/hello/index.js
• npm run build:actions && npm run deploy:actions or aio cna deploy -av

Expected Behaviour

Action sequence should be covered by the UI build script so that it can be called from the UI.

Actual Behaviour

Sequences can not be called from the UI.

Reproduce Scenario (including but not limited to)

Applications that need to invoke a sequence of actions instead of single actions.

Steps to Reproduce

In manifest.yml, add sequences section:

packages:
  __CNA_PACKAGE__:
    license: Apache-2.0
    actions:
      hello:
        function: actions/hello/index.js
        web: yes
        runtime: 'nodejs:10'
      hello2:
        function: actions/hello/index.js
        web: yes
        runtime: 'nodejs:10'
    sequences:
      hello-sequence:
        actions: hello, hello2

Platform and Version

Sample Code that illustrates the problem

Please see Steps to reproduce.

Logs taken while reproducing problem

Action deployment hangs forever when having a dependency to openwhisk module + parcel minification on build

Actual Behaviour/Reproduce Scenario (including but not limited to)

1. npm install openwhisk
2. add const openwhisk = require('openwhisk') on top of actions/hello/index.js
   All of those hang:
   npm run deploy:actions
aio cna deploy -av
aio runtime create hello dist/actions/hello.js
   Weird error message, cluttered output with wsk
   wsk action create hello dist/actions/hello.js