adobe-rnd / github-purge-cache-action Goto Github PK

https://github.com/koraa/hlx-gh-action-purge-updated-cache/blob/b62f779d658b7e4ebfe5b6389ec92325a828641c/index.js#L56

the outer CDN url should be optional

that the primary use of the purge action is to purge the outer CDN (and the inner CDN).

i think that keeping the inner CDN in sync with the content/code especially with github is something that needs to happen automatically and in that sense i would rather separate that from this action. i am worried that if we get to a place where we require purging on commits for the inner CDN we will start making the initial hurdle for someone to get started with a helix project higher.

so in my mind this is acceptable complexity for someone who goes live with a helix project on a real domain, but not for someone who is in development.

please output all the files that were purged, so that the developer has a way to verify that the action works.

suggest an input property 'include':

on: push

jobs:
  ci_trigger:
    runs-on: ubuntu-latest
    name: Clear helix pages cache
    steps:
      - name: Trigger
        id: trigger
        uses: adobe-rnd/github-purge-cache-action@master
        with:
          repo-token: ${{ secrets.MY_GITHUB_TOKEN }}
          include:
            - /scripts*
            - /styles*

the filtering should use https://www.npmjs.com/package/glob

i think it would be great if the repo-token was optional as it is not immediately clear why a regular helix pages project (which lives in a public repo and has very few pushes) would require that, it may very well be that it is optional already, the documentation in the README.md suggests it is required.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update dependency @actions/core to v1.9.1 [security]
• fix(deps): update dependency ferrum to v1.9.4
• fix(deps): update dependency phin to v3.7.0
• fix(deps): update dependency @actions/github to v6
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

currently, helix-pages only supports a default branch of master, but in the future this might change.
the purge action should not hardcode master for getting the diff, but use either the default branch of github, or make it configurable.