Git Product home page Git Product logo

admin-theme's People

Contributors

lagar84 avatar rmpestano avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

admin-theme's Issues

Box shadow on focus for input errors

Currently the 'focus shadow' is the same for inputs with or without error:

box-shadow

error-box-shadow-actual

We should apply a different shadow on input with error state, like below:

error-box-shadow-expected

SelectCheckboxMenu trigger is not rendered correctly

As reported here. The problem happens when

multiple="true"
<p:selectCheckboxMenu id="usuarioFiltro"
				value="#{tarefaPortalBean.userSelecionado}" label="Usuários"
				multiple="true" filter="true" filterMatchMode="startsWith"
				panelStyle="width:250px"
				converter="omnifaces.SelectItemsConverter">
				<f:selectItems value="#{tarefaPortalBean.usuarios}" var="u"
					itemLabel="#{u.name}" itemValue="#{u}" />
			</p:selectCheckboxMenu>

8bb19ef0-2a02-11e7-9309-889e7800fae0

p:inputNumber not well showed

inputnumber

        <div class="container">

            <div class="col-lg-12">            

                <div class="row">

                    <h3>Nova Factura</h3>

                    <div class="control-group form-group">
                        <div class="controls">
                            <label>Import Factura:</label>

                            <p:inputNumber styleClass="form-control" id="importfactura" value="#{controlFacturacio.facturaventa.importfactura}" symbol=" EUR" symbolPosition="s" 
                                           decimalSeparator="," thousandSeparator=".">  
                            </p:inputNumber>                                  
                        </div>
                    </div>




                </div>

            </div>            
        </div>            

Chip label misplaced

Like said on Twitter, when an issue is found, i will create an account and file them. Keep up the good work, i really like the theme implementation!

I found the following:
When adding a chip the label is misplaced

chip_error

The below is what was expected

chip_expected

This is fixed by overriding this in the admin template with:
span.ui-autocomplete-token-label { display: inline-block; }
This currently is display: block.

Affected version: RC6
Browser: Chrome 58.0.3029.110 (Official Build) (64-bit)
OS: Windows 10

selectCheckboxMenu misrendered in Firefox

Issue Overview

selectCheckboxMenu with type multiple is misrendered in Firefox

Current Behaviour

Selected items doesn't contain the close icon to remove item, also looks there is some aditional padding:

selectcheckmany

Expected Behaviour

Close icon should be rendered on selected itens so they can be removed:

expected

How to reproduce
 <p:selectCheckboxMenu id="chkmenu-multiple" label="Cities"
                                          multiple="true" filter="true" filterMatchMode="startsWith">
                        <f:selectItems value="#{checkboxMB.cities}"/>
                    </p:selectCheckboxMenu>
Additional Information
  • Affected version: 1.0.0-RC6
  • Browser version: Firefox 53.0.3 (64-bit)

Promo video

Create a video showing AdminFaces main features.

Hability to generate theme without bootstrap

Currently admin theme comes with bootstrap.css embbeded.

Create a classifier, similar to dev classifier, named without-bootstrap in order to generate a theme.css file without bootstrap.

The usage may be something like:

<dependency>
    <groupId>com.github.adminfaces</groupId>
    <artifactId>admin-theme</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <classifier>exclude-bootstrap</classifier>
</dependency>

Treetable mutiple selection blank checkbox

Issue Overview

The checkbox in treetable with multiple selection is blank

Current Behaviour

treetable-multiple

Expected Behaviour

treetable-multiple-expected

How to reproduce

Just use a treetable with selection type checkbox

 <p:treeTable value="#{treeTableMB.root}" selectionMode="checkbox" selection="#{treeTableMB.selectedNodes}"

...
Additional Information
  • Affected version 1.0.0-RC6
  • Browser versio: any

Provide a mechanism to deal with cached theme.css

Issue: When users update admin theme version they see css issues in components. Same happens with standard or premium primefaces themes, see here: primefaces/primefaces#1598

Solution:

One solution is to use OmniFaces combined resource handler and make it work with the theme, see example here: https://github.com/omnifaces/omnifaces/wiki/Combine-hardcoded-PrimeFaces-resources-using-CombinedResourceHandler.

Another solution is to create a maven classifier with the theme version, example:

 <dependency>
    <groupId>com.github.adminfaces</groupId>
    <artifactId>admin-theme</artifactId>
    <version>1.0.0-RC5</version>
    <classifier>RC5</classifier> 
</dependency>

and in web.xml:

<context-param>
    <param-name>primefaces.THEME</param-name>
    <param-value>admin-RC5</param-value>
 </context-param>

The first solution can be implemented by theme users in their applications. The second one needs to be provided by admin-theme.

Style Treetable

Treetable needs to get some admin style.

Actual rendering:

treetable-actual

calendar not well showed

error

errro2

        <!-- Page Content -->
        <div class="container">

            <div class="col-lg-12">            

                <div class="row">

                    <h3>Send us a Message</h3>
                    <div class="control-group form-group">
                        <div class="controls">
                            <label>Full Name:</label>
                            <input type="text" class="form-control" id="name" required-message="Please enter your name.">
                                <p class="help-block"></p>
                            </input>
                        </div>
                    </div>
                    <div class="control-group form-group">
                        <div class="controls">
                            <label>Phone Number:</label>
                            <input type="tel" class="form-control" id="phone" required-message="Please enter your phone number.">
                            </input>
                        </div>
                    </div>


                    <div class="control-group form-group">
                        <div class="controls">
                            <label>Date:</label>

                            <p:calendar class="form-control" value="#{controlFacturacio.facturaventa.datafactura}" />

                        </div>
                    </div>


                    <div class="control-group form-group">
                        <div class="controls">
                            <label>Tag:</label>

                            <p:selectOneMenu id="car" value="#{controlFacturacio.tagSeleccionat}" converter="omnifaces.SelectItemsConverter" >
                                <f:selectItem itemLabel="Select One" itemValue="" />
                                <f:selectItems value="#{llistaTagLists}" var="tag" itemValue="#{tag}" itemLabel="#{tag.nomTag}" />
                            </p:selectOneMenu>      

                        </div>
                    </div>

                    <div class="control-group form-group">
                        <div class="controls">
                            <label>Tag:</label>


                            <p:selectOneMenu id="console" value="#{controlFacturacio.tagTextSeleccionat}">
                                <f:selectItem itemLabel="Select One" itemValue="" />
                                <f:selectItem itemLabel="Xbox One" itemValue="Xbox One" />
                                <f:selectItem itemLabel="PS4" itemValue="PS4" />
                                <f:selectItem itemLabel="Wii U" itemValue="Wii U" />
                            </p:selectOneMenu>                                    


                        </div>
                    </div>


                    <div id="success"></div>


                    <p:commandButton ajax="true" value="Crea Factura"  icon="fa fa-plus" styleClass="btn-primary" actionListener="#{controlFacturacio.creaFactura(actionEvent)}" />          


                </div>

            </div>            
        </div>       

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.