adhocore / please Goto Github PK

root:/var/www/project# please --vfile --chlog --version 1.11.1
Repository crazyfactory/logistics
Log file /tmp/PLZ.bXl2hirNbc
Updating master ...
  Done
Getting latest releases ...
parse error: Invalid numeric literal at line 1, column 2

Env:
docker container: php-fpm
token auth: public_repo, repo_deployment

• please --before-github "bash cmd"
• please --before-npm "bash cmd"
• please --after-finish "bash cmd"

support npm publish if there's package.json (not marked private)

currently it is based on major/minor arg

should be based on first word of any of the commit message:

fix: => patch no need because this is default
feat: => minor <-- this will be fixed :)
bc: => major (confirm bc) no need because bump major has to be conscious decision and should use: please major --flags

since it is causes trouble with json encoding

I'm getting the following when trying to use it.

/usr/local/bin/please: line 26: syntax error near unexpected token '>'

I'll try to look into this myself and send a PR this weekend.

expected

please major should release v2.0.0

actual

please major releases v1.0.0

reason

the issue is major part v1 is treated as 0 as it is not numeric

solution

• if latest VERSION starts with v, set V=1 and strip v (i.e replace with empty string)
• determine NEXT_VERSION as usual
• if V == 1, prepend v to the NEXT_VERSION

see https://github.com/adhocore/please/releases/tag/0.0.9
the release note which is composed of commits looks like

fix(please): silence npm, show version after bump

docs: update usage

but it should be:

fix(please): silence npm, show version after bump
docs: update usage

i.e without extra NL between two commits.

where to fix: https://github.com/adhocore/please/blob/master/please#L207

in release note and changelog

I wish there was an option to specify the assets to upload to github once the release is done.
For instance:

please --asset dist/release-{NEXT_VERSION}.zip

maybe GitHub api got changed or something?

(confirm can still be skipped by --yes, -y)

group the commits by type Feature, Fix, Refactor, Test, Others

### Feature
- ..
- ..

### Fix
- ..
- ..

Some git api endpoints (see below) are curled without auth header which might affect private repos

curl --silent "https://api.${GH_REPO}/releases/latest

The readme says:

Make sure to set only bare minimum permission scopes for this token.

What permissions should be set?

don't rely on php except for phar compile

• for now travis only