adharaprojects / cbs-proxy Goto Github PK

Currently cbs proxy only handles the omnibus account id, and there is no way to get a user's account id from the cbs-proxy

Child of https://github.com/AdharaProjects/cash-tokenizer-ui/issues/61

This is similar to #43

This will allow us to increase the speed of login even more.

Currently the best possible is to first get the session token, and then get the account details with the session token.

When this is implemented we will be able to use a Promise.all and get all the information directly using the username+password in one step.

child of #36

Using Oclif at the moment, I tried a few other frameworks such as commander, yargs, inquirer. But Oclif seems best (if you have input experience let me know).

I'm planning to use configstore npm package to handle default configs for the commands which users can configure, tag and use depending on their usecase.

Right now cyclos needs some setup before one can run tests against it's routes. Before one can add this project to circle CI one would need to have a cyclos that has been configured to allow webservice logins etc

Connects https://github.com/AdharaProjects/admin-cli/issues/1

We should come up with a logical, standard and uniform way of expresing these endpoints. At the moment it is very messy, since the functions were just added to get something working. Now that we have some perspective we can start to decide how to do this properly.

Some discussion around this here: #29 (comment)

Connects https://github.com/AdharaProjects/admin-cli/issues/1

for /subscribeToAccountDetails, when polling CBS, do diff and only emit SSE when necessary

currently, the endpoint emits a ton of redundant events

main frustration atm it's a lot of unnecessary clutters in the inspector tools for FE dev

The files named "transfer.js" and "transfers.js" are confusing. "transfers.js" should be renamed to "transferLog" or "transferList", or even "previousTransfersList".

This is similar to #42

This will allow us to increase the speed of login even more.

Currently the best possible is to first get the session token, and then get the account details with the session token.

When this is implemented we will be able to use a Promise.all and get all the information directly using the username+password in one step.

child of #36

We are investigating whether moving CBS interaction from polling to subscription will improve performance.

Since the cbs-proxy is currently specifically made to work with cyclos, perhaps we should consider renaming it to cyclos-proxy (and perhaps some work is needed to genericize the cbs-proxy-client as well)?

The most important piece of information is their account number. But their balance and other info would also be useful.

Waiting for response: cyclosproject/ng-swagger-gen#72

child of adharaprojects/adhara-docs#9

child of adharaprojects/cash-tokenizer-ui#97

The latest Cyclos has some performance improvements apparently. And the fix is relatively easy.

When you try send a transfer from the omnibus account to a user you get the following error:

The fix is simple, add the subject to the request body - then it works:

Do this in the blockchain-proxy as well

Only reason this isn't included in the change is that this change is reasonably urgent.

requires AdharaProjects/cbs-proxy-client#20

Child of https://github.com/AdharaProjects/account-mirror-proxy/issues/1

Once we have completed the investigation around polling the CBS and a subscription service, we can also look at the login process to improve performance.