Comments (8)
That's great, thank you!
from tiddle.
@adamniedzielski, I have changed the requirements to be the same as devise 3.4.1, as that seems the most sensible thing to do. This means, I had to change the few lines of code you had that relied on ruby 2.1.
I use RVM to manage my gems and ruby versions, but I didn't add a .rvmrc. Let me know if I should add it to the project.
Tests all pass running under jruby 1.7.20. But, how do they work? The test rails app doesn't have a database.yml. I created a database.yml for postgresql, but, it doesn't seem to use the database while running the tests.
Finally, once I get tiddle integrated in my main project, and it is all working, I'll send you a push request. For now, you can look at my fork here.
from tiddle.
I took a look at your fork. Can you tell me which version of MRI Ruby is jruby 1.7.20 compatible with? I don't want to support Ruby 1.9.3 - it doesn't even receive any security fixes now.
I also use RVM, but I don't think that committing .rvmrc
or .ruby-version
file is a good idea. .ruby-version
is even added to .gitignore
-
Line 16 in 022ef69
Database URL is hardcoded here:
Line 13 in 022ef69
Can you add Ruby versions for which you introduce support to .travis.yml
?
Thanks for your time!
from tiddle.
Sadly, jruby 1.7 does not support MRI 2.x. They plan to support 2.2.x when jruby 9000 comes out.
Woops, I seem to actually have done the right thing, and use sqllite via the ARJDBC adapter.
I too would like to take advantage of all the new MRI 2.x features. Maybe in another 6 months, it will be possible.
from tiddle.
So, jruby 1.7 is the latest stable version of jruby and it's compatible with Ruby 1.9.3 - do I understand it correctly? If so, feel free to make changes to support it.
from tiddle.
Yes, this is correct. Sadly the current stable version of jruby, 1.7.20, only supports Ruby 1.9.3.
I'll remove the database.yml file, but I will leave the Gemfile with it's changes for the database adapters.
Pull request should be winging its way to you later today.
from tiddle.
Hi @ninkibah ! Any progress on this? Are you still interested in adding support for jruby?
from tiddle.
I'm closing this as outdated.
from tiddle.
Related Issues (20)
- Version 1.0 HOT 2
- Fix Rubocop offences
- DEPRECATION WARNING: ActionDispatch::IntegrationTest HOT 7
- Error after installed Tiddle HOT 3
- Can't change maximum token per user
- Support devise > 4.3.X HOT 2
- Time-based expiration mechanism for tokens HOT 7
- Remove unnecessary secure compare
- Devise 4.4 HOT 4
- [Question]: What for sending X-USER-EMAIL ?
- Update required fields for README HOT 2
- Tiddle can not work with devise 4.5.0. HOT 3
- Soft purge setting `revoked_at` instead of destroying auth tokens? HOT 2
- Devise can not be updated past version >=4.6
- [Question] Cookieless Tiddle & ActionCable HOT 2
- Multiple types of Users HOT 1
- Token last_used_at not being updated properly HOT 5
- Tokens pile up in the database forever HOT 1
- Switch dev setup to use Docker
- Mongoid support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tiddle.