Token last_used_at not being updated properly about tiddle HOT 5 CLOSED

Hey @bruno-campos, thanks for the write-up 💚

Yes, the reason for updating last_used_at only if it wasn't updated in the last hour is to prevent extra database requests. Otherwise we will be making a database call on every request, even GET requests, which is quite nasty. I think that having an approximate value in last_used_at is acceptable. This behaviour has been part of this gem since the very beginning.

Expiring tokens were introduced later. I've never considered the case of what happens if expires_in is smaller than 1 hour. You're right - there's a bug in this scenario.

from tiddle.

@adamniedzielski Is there any harm in adding an optional configuration like @bruno-campos drafted here? This gives users the plug'n play out of the box experience while also supporting the ability to customize to their use case.

from tiddle.

I can see that you fixed it for yourself in your fork 👍 👏

from tiddle.

@adamniedzielski I am experiencing the same difficult, I have to set 15 minutes of inactive timeout.

Even that it shouldn't be configurable, I believe it should work with short times.

Could we reduce the interval to 1 minute? Or maybe we could have a replaceable default value.

I wouldn't like to create a fork or something like that.

from tiddle.

We could add the interval when creating the token as we do with the expires_in, if no value provided, we keep the default behavior.

from tiddle.