NullBooleanField upgraded to BooleanField in migrations file about django-upgrade HOT 4 CLOSED

Ah os.path.sep is incomplete, we need to use altsep too, if not None: https://docs.python.org/3.10/library/os.html#os.altsep

would you like to make a PR changing that instead?

from django-upgrade.

looks_like_migrations_file is really simple:

Can you try and debug why it’s not returning True? Seems like it could be a Windows/Powershell issue.

from django-upgrade.

Hi Adam,

it may be indeed a combining PowerShell & git ls-files issue. git ls-files -- '*.py' outputs the following:

...
projects/migrations/0001_initial.py
projects/migrations/0002_auto_20200512_1030.py
projects/migrations/0238_auto_20200424_1249.py
projects/migrations/0239_auto_20200430_1526.py
projects/migrations/0240_auto_20200505_0954.py
projects/migrations/0241_auto_20200514_1155.py
...

When this is passed to looks_like_migrations_file, this results in the following:

ipdb> self.filename
'projects/migrations/0238_auto_20200424_1249.py'

ipdb> os.path.sep
'\\'

ipdb> self.filename.split(os.path.sep)
['projects/migrations/0238_auto_20200424_1249.py']

As the separator used by git ls-files (and git bash in general) does not match the os.path.sep.
replacing the '/' did the trick:

git ls-files -- '*.py' | %{django-upgrade --target-version 4.1 $_.replace('/','\\')}

Is this something to be added in the docs? Or added as an argument?
An example doc change is present here:

I've added this as PR-285 is this seems OK for you.
Otherwise I'd gladly add it as an argument (to be used instead of os.path.sep if one is given).

from django-upgrade.

Not sure if using os.sep and os.altsep is the best way to do this:
Splitting on two delimiters can be done with re.split, the pattern will be something like:

sep_re = rf"[{os.sep}{os.altsep or ''}]"
# or to keep it simple:
sep_re = r"[\\/]"

Not sure if getting the path seperator from os would have an added value here.
But if we're already going into regex land, maybe simplifying to the general approach in data.py would be a better solution:

migrations_re = re.compile(r"(^|[\\/])migrations([\\/])")
commands_re = re.compile( r"(^|[\\/])management[\\/]commands[\\/]")
...
    @cached_property
    def looks_like_command_file(self) -> bool:
        return commands_re.search(self.filename) is not None
...
    @cached_property
    def looks_like_migrations_file(self) -> bool:
        return migrations_re.search(self.filename) is not None
...

also simplifying the following part as marked above:

Is this ok for you?

from django-upgrade.