Git Product home page Git Product logo

Comments (5)

OscarVanL avatar OscarVanL commented on July 30, 2024 1

I can only apologise for coming across that way. I appreciate all the work you have done to help simplify these upgrades for the community.

I did bump into another couple of things that it could have auto-changed, for example the attribute naming in the ForeignKey class:

  • Switch ForeignKey.rel to ForeignKey.remote_field

  • Switch ForeignKey.rel.to to ForeignKey.remote_field.model

But likewise, as @adamchainz pointed out, it might not be worth adding these to the tool for such an old Django version.

from django-upgrade.

OscarVanL avatar OscarVanL commented on July 30, 2024

Also ran into this when upgrading, which django-upgrade missed :)

from django-upgrade.

adamchainz avatar adamchainz commented on July 30, 2024

Django 2.0 was released nearly six years ago. At this point, I don’t really care to implement a fixer for the handful of projects that will use it, but would review a PR.

from django-upgrade.

OscarVanL avatar OscarVanL commented on July 30, 2024

That's fair enough - to be clear that wasn't a criticism, the tool has been extremely helpful.

from django-upgrade.

UnknownPlatypus avatar UnknownPlatypus commented on July 30, 2024

That's fair enough - to be clear that wasn't a criticism, the tool has been extremely helpful.

Ye that was not really clear from your previous comment which felt a bit passive-aggressive in my opinion, thanks for the clarification.

I'll submit a PR for review later today to support this, I think this can be easily done following changes made in #295

from django-upgrade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.