adafruit / adafruit_circuitpython_as7341 Goto Github PK

Is there a way to get a reading from the Clear and NIR channels on the AS7341? On line 379 of 'adafruit_as7341.py' it is still listed as a TODO. Is this still something that is planning on being added? Thanks so much!

The documentation now says types astep and atime correctly for linters, but not so well for library usage (since the __get__() and __set__() methods mean the actual return values are different. Not sure the correct fix, but wanted to document it for now at least.

I assumed 415 meant the measurement was centered at 415nm, though I'm wondering now based on the description of "415nm band" etc. Do you mind clarifying? Where it's centered? What kind of width it has?

Hello,
I am using this code with the AS7341 and a Raspberrypi. I am trying to calibrate the sensor readings with a Spectrometer and I have faced an issue. It seems that the F5-F8 channel readings are incorrect. To verify that it is not a sensor limitation issue, I compared the readings with the readings of the same sensor connected to an Arduino using c++ code (https://github.com/adafruit/Adafruit_AS7341/blob/master/Adafruit_AS7341.cpp). The ATIME, AGAIN, and ASTEP parameters are kept the same in both platforms. The values for the F5-F8 are completely different and those that are obtained with the c++ code are consistent with the actual spectrometer. I cannot day I fully understand the code, but I am guessing something is going wrong in the SMUX config in "_f5f8_clear_nir()". Would anyone please be able to provide some insight into this?

The docstring says: """Resets the internal registers and restores the default settings""", but the function is empty.

Apologies if this is on the todo list already.

I tried toggling self._power_enabled as a quick workaround, but previous values persisted.

How can I get the clear channel reading?

Maybe instead formalize second parameter on request to namedtuple as a square bracketed list of string items or as a string containing items delimited by comma space? Maybe CircuitPython can't handle the necessary string to list conversion.

Am attempting to implement software based spectroscope for educational demonstrations using Adafruit # 3500 Trinket M0 connected to Adafruit # 4698 AS7341 breakout.

First time submitting regarding Adafruit offerings. Please let me know if my style and content are conformant to expectations.

According to the datasheet the default should be 9 or 256x:

I could see this being an issue for someone coming from Arduino or looking at the datasheet graphs.

Setting the LED current to 0, with sensor.led_current=0 gives the unexpected result of actually setting the current to the maximum value possible, due to wrap around in the calculation.

Suggest modifying line 620 of file to:

    new_current = max(0, min(127,int((led_curent - 4) / 1)))

to coerce current being set to valid range.

regards
dave Langstaff

sparks-baird/self-driving-lab-demo#17

i.e. astep and atime

Is this as simple as:

i2c = board.I2C()
sensor = AS7341(i2c)
sensor.astep = 10
sensor.atime = 100

(similar to the flicker detection example, modifying the property after class instantiation)

Also, what are the default values for these?

The syntax here:

Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit QT Py M0 with samd21e18
>>> from collections import namedtuple
>>> foo = namedtuple("foo", "x y z")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: object 'str' is not a tuple or list
>>> foo = namedtuple("foo", ("x","y","z"))
>>>  

There are missing type annotations for some functions in this library.

The typing module does not exist on CircuitPython devices so the import needs to be wrapped in try/except to catch the error for missing import. There is an example of how that is done here:

try:
    from typing import List, Tuple
except ImportError:
    pass

Once imported the typing annotations for the argument type(s), and return type(s) can be added to the function signature. Here is an example of a function that has had this done already:

def wrap_text_to_pixels(
    string: str, max_width: int, font=None, indent0: str = "", indent1: str = ""
) -> List[str]:

If you are new to Git or Github we have a guide about contributing to our projects here: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

There is also a guide that covers our CI utilities and how to run them locally to ensure they will pass in Github Actions here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code In particular the pages: Sharing docs on ReadTheDocs and Check your code with pre-commit contain the tools to install and commands to run locally to run the checks.

If you are attempting to resolve this issue and need help, you can post a comment on this issue and tag both @FoamyGuy and @kattni or reach out to us on Discord: https://adafru.it/discord in the #circuitpython-dev channel.

The following locations are reported by mypy to be missing type annotations:

• adafruit_as7341.py:106
• adafruit_as7341.py:108
• adafruit_as7341.py:121
• adafruit_as7341.py:133
• adafruit_as7341.py:297
• adafruit_as7341.py:391
• adafruit_as7341.py:399
• adafruit_as7341.py:478
• adafruit_as7341.py:635
• adafruit_as7341.py:648
• adafruit_as7341.py:658
• adafruit_as7341.py:675
• adafruit_as7341.py:687
• adafruit_as7341.py:697