ada-url / ada-python Goto Github PK

It seems we are not releasing a new version on pypi.org and github releases. Should we make the releases automatic just like Ada?

cc @bbayles

Noted in #47:

Why do we include .o, .cpp, .c, .h files in the wheels? Afaik, ada works well without them.

This issue is to drop them from binary distributions.

@TkTech did an amazing job with https://github.com/TkTech/can_ada. I think we should follow the path, or maybe merge the two implementations, since it is 2 times faster and the goal of Ada project is performance?

What do you think @lemire @TkTech @bbayles?

This issue is to incorporate the IDNA functions from ada-url/ada@39e114a into this Python library, as part of updating to version 2.6.0.

https://github.com/ada-url/ada/releases/tag/v2.7.2 has the latest release: publish a Python package for it!

Since Astro team released uv recently, should we try it with ada-python?

It was released recently - I will switch to it.

This issue is to update the ada library to the 2.6.9 version, which was just released. Assigning this to myself as a reminder to do it when I get back from a trip.

I'd like to get https://readthedocs.org/dashboard/ada-url/ working. I can set this up myself if granted access to the settings for this repo that would allow me to configure the GitHub/RTD integration.

Failing that, I could add existing repository admins to the RTD and have them set up the integration.

My branch here should allow for RTD to install the library to allow the inline docstrings to be rendered.

Currently we have no annotations at all. Since most parameters and return are str, it is fast to fix it.

If it is needed, I'll give the pr.

How does ada-python perform compared to urllib?

We currently use GitHub Actions and cibuildwheel to build wheel packages for Linux and Mac. However, it should be possible to also create Windows wheels.

Noted in #46:

pip install ada_url --no-binary ada_url will fail (on both Linux and Windows) because of the absence of ada.o

We would need to move the step that builds ada.o into the python -m build step. I looked into doing previously, but couldn't figure out a portable method.

This library fails on one of the parsing tests here:

http://example.com/\uD800\uD801\uDFFE\uDFFF\uFDD0\uFDCF\uFDEF\uFDF0\uFFFE\uFFFF?\uD800\uD801\uDFFE\uDFFF\uFDD0\uFDCF\uFDEF\uFDF0\uFFFE\uFFFF

It is due to this error:

'utf-8' codec can't encode characters in position 19-22: surrogates not allowed

It appears that ada uses simdjson's get_string function with replacement characters. We can probably do the same thing in Python, though a quick test of these didn't work as expected:

• replace
• backslashreplace
• surrogatepass