core-unit-2's People
core-unit-2's Issues
create-and-read: "Getting a Single Book Endpoint: Code": `get` method is deprecated in SQLAlchemy 1.4.
I think Jasmine saw that the get
method is deprecated in SQLAlchemy 1.4. For reference, get
is essentially equivalent to:
book = Book.query.filter(Book.id == book_id).one_or_none()
Not saying we should give this instead, but wanted to surface that there is a "significant" deprecation coming up.
Originally posted by @anselrognlie in #7 (comment)
Rename "Sorting Algos" folder, topic names, asset files, config, etc to "Sorting Algorithms"
we can probably afford to spell out Algorithms.
Title: Sorting Algorithms
Originally posted by @anselrognlie in #9 (comment)
create-and-read: Flask POST /books endpoint: Variable that shadows its function
a little uneasy recommending the use of a variable that shadows its function. Consider renaming to reduce the chance of confusion.
Since we're using this method above, probably would be better here to rename the var. Maybe queried_books?
If this is too much to change, we can get by as is, but I'd like to see us try to avoid this.
Originally posted by @anselrognlie in #7 (comment)
this screen shot (update-and-delete_update-precheck-get.png) shouldn't show the json request body (since it's not used in the GET)
this screen shot (update-and-delete_update-precheck-get.png) shouldn't show the json request body (since it's not used in the GET)
images should be renamed and resized throughout
Originally posted by @anselrognlie in #8 (comment)
`SQLALCHEMY_TEST_DATABASE_URI` is fine for a name, but personally, I would go with `SQLALCHEMY_DATABASE_URI_TEST` whenever I have a variable that has an environment as part of the name. If this is done consistently, this allows for a configuration pattern where can set un-versioned defaults, but then provide per-environment values by trying to find an equivalent var with the environment appended.
SQLALCHEMY_TEST_DATABASE_URI
is fine for a name, but personally, I would go with SQLALCHEMY_DATABASE_URI_TEST
whenever I have a variable that has an environment as part of the name. If this is done consistently, this allows for a configuration pattern where can set un-versioned defaults, but then provide per-environment values by trying to find an equivalent var with the environment appended.
We don't really need this here (the test db is largely a one off, and if we had staging/production, we would be supplying an entirely separate environment configuration (probably through a dashboard), so we definitely do NOT need to change this, but I wanted to mention it.
Originally posted by @anselrognlie in #11 (comment)
flask-hello-books: Screenshot in "Manually testing the hello world endpoint." The url shown in the screenshot does not match the url referenced in the text.
The url shown in the screenshot does not match the url referenced in the text.
Originally posted by @anselrognlie in #7 (comment)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.