ada-developers-academy / classroom-app Goto Github PK

Add a new feature/page which will add a link for each feedback.md file for each repo currently in the system. This will provide an "at a glance" view for all feedback templates that we have created.

(Sidenote: Maybe it would be good to do the same thing for the student self-reflection templates)

This might be a TODO item for me.

I like the idea of being able to do a whole github review, make inline comments, etc. However, as of now the PR app does not pick up reviews made on GitHub, only ones made through the app.

Add a feature that will allow us to pre-assign feedback to instructors so we are clear about who is reviewing which student's assignments.

In various places we list the date for a thing (project submission, feedback given) and it'd be simpler to read if we presented those dates as relative times.

Also we currently show all dates in GMT, so we should probably change the time zone for the project to Pacific Time.

As it stands, there's no way to see who's in a group together, or to make sure that feedback goes to both group members. Also, half the students look like they haven't submitted.

1. It should include date assigned or added or submitted or something
2. It should be sortable (use datatables, like all the other ones)

Would be nice to be able to click a button to see a form (inline?) to edit the results for a student. Either to change a color if needed, or to add a feedback link if somehow it was missed.

When send a student a reminder to turn in an assignment for Queues, jamie's email is missing the 'e' at the end and bounces back.

I wonder if we might be able to incorporate Dan's project download script into the app somehow so you could just hit a "download" button or some quick way to retrieve all student assignments locally.

Right now we use only the list of commit authors to determine participation. We should instead use all available data, including who submitted the PR.

This will enable us to do things like determine which project is currently active, and to optimize our GitHub API access by filtering out projects that are no longer active.

I'm on it!

https://github.com/OscarGodson/EpicEditor

For example, when we destroy a Repo it does not destroy all associated Submissions.

The app should use the instructor's github credentials to post feedback.

When submitting feedback for Jou-Jou, I'm getting an error.

On the feedback view, we should add a field (DB & UI) to identify which instructor left the feedback

We should be able to see a high-level submission view for students and filter by category. This should include the red/yellow/green for certain categories, and simply submitted/not-submitted for other categories.

First, must implement Issue #76

• Add validation for repo URL format
• Feeback.md existence
• Anything else!?

On this page http://classroom.adadevelopersacademy.org/pull_requests of the PR app, could there count be a count added after student submissions like (4 out of 24) or (all submitted) so it’s easy at a glance to see if anything is missing?

When a student changes their github username, our system can no longer pick up their PRs. Don't know if it's possible, but it would be great if we could track students internally by some sort of GitHub UUID that doesn't change.

We should be able to classify assignments under the specific areas in which they are assigned: Ruby, Rails, JS, CS Fun

Minor issue, but sort of silly looking.

Repro steps: submit feedback for a PR.

Not sure we want to do this but it looks like EpicEditor has been abandoned as of ~2016 and
Markdown.js looks like it might do what we want.

Right now if you create a Repo that does not link to an actual GitHub project then attempt to view the submissions list for that Repo, you will receive a 500 error.

We should check for this case and provide a more meaningful error message.

When feedback has been submitted for a particular PR submission, we can't see (within the app) who submitted that feedback.

When all students in a given cohort have submitted, we should no longer query the API on the first submission listing.

It'd be nice if on the student page(?) There was some kind of tally of the number of late assignments or non-turned in assignments for each student. So that build up of these behaviors is easily recognizable.

Maybe even an alert if a student exceeds a certain threshold. 3 late assignments? 2 non-submitted assignments?

Expected behavior: tables have a default sort order, and can be sorted by any column by clicking on the column header.

Observed behavior: tables render unsorted, and do not have any way to sort

Additional Info:

Similar to #40, though possibly a different root cause. Maybe a jquery/turbolinks thing?

The JS library we use to manage that behavior is called "data-tables" or something like that.

When Issue #1 is implemented, we should be able to associate these users with the cohort repos. This should then allow us to populate the CC line for the student e-mail so their instructor(s) will be notified.

Previously, you could click the little icon in the table headers and it would sort the table, at least on the submission page. That functionality currently does not appear.

Probably a mis-merge. I will go attempt to fix right now.

It would be good if we linked to GitHub where we list our student's github user names are listed

This PR submitted by cecomfort against Word Guess isn't showing up in the submission list.

I do not know why. Many of the students are marked as "not having submitted" because it's a pair project - that's tracked as a separate issue. But Cara is the one who submitted for her group, so I would expect to see her there.

Writing this down so I don't forget to follow up on it.

On the student list view, it would be good if the email addresses listed linked to automatically compose an email to that email address

The User role code is implemented but creating a new User does not assign a role, which breaks our validations.

Due to the fact that the main pull request API URL does not contain committer info, group projects are slow:

• They must complete another API request which lists all commits
• We try to limit the number of commits we go through, but we still must request all of the API data
• No loading indicator or useful feedback on what is taking so long

See a table of all students in a class with:
• Each project with overall grade
• Instructor-specific notes
• Anything else?

Most of the time we're using the app we want to see information about the most recent project, so that should be listed first.

We could either:

• Implement the sorting gem that Dan uses on other views
• Add default sort of repo date created desc (right now it's asc)

Occasionally we have students who defer to a later cohort and it would be good if we could mark them as inactive in the app so that they do not keep showing up as having missed a PR.

It is not currently possible to edit or update feedback (both the detailed comment form and the grade) after it has been submitted.

On page https://classroom.adadevelopersacademy.org/repos/195/students/216/feedback/new

Looks like this changed with the re-deploy today? Issues I observe:

• Using a non-monospaced font
• The textarea doesn't get bigger if the feedback doc is bigger
• The markdown preview feature seems to be broken (I don't see the controls appear)

It should be possible for students to log into the application and view a list of their own projects with submitted PRs and feedback (if posted).

I would like to be able to pre-determine the user's who can use this application. This should most likely be restricted to a certain GitHub group that would correspond to Ada staff.