Git Product home page Git Product logo

axesor's Issues

The `!` filter doesnt work

I would like to do something like this: ['*', '!name'] - allow all fields but exclude name from it. It seems to be not working.

Owner function called multiple times

Is calling owner function for each match in grant intended feature or a bug? Example:

const axesor = require('axesor');

const grants = {
  admin: {
    video: {
      'read:own': ['*']
    }
  },
  reader: {
    video: {
      'read:own': ['*']
    }
  }
} 

const options = {
    getRoles: () => ['admin', 'reader'],
    ownerFunctions: {
      video: () => {
        console.log('video owner function')
      }
    }
};

const ac = new axesor.Acl(grants, options);

ac.can({}).read({ title: 'test' }, 'video');

video owner function is called twice in that case

https://repl.it/join/yvpignqp-jevhenijhorvat

Unnecessary permission attributes

This issue is side effect of the issue #6.

The part of code attributes: !attributes.includes('*') ? attributes : ['*'] in the Acl.ts on the line 116 was changed.

Now permission attributes will look like this: ['*', 'author', 'title'] if you grant access to the ['*', 'author', 'title']. The previous part of code should not be here because of exclude filters - ['*', '!name'] - result was ['*'].

We need to add some filter for this cases. If grants contains exclude then keep attributes and if not then use the * (only if * is defined).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.