ackeecz / ackategories Goto Github PK

It's possible to make UIColor from hex string, it would be useful to also have a method to make hex string from existing UIColor 🙏

It is a while since Xcode supports multiplatform targets. This way we can merge ACKategoriesCore and ACKategories-iOS targets in Carthage project to make development a bit easier.

This way we can also simply add support for more platforms - tvOS, watchOS, visionOS, etc.

It would be necessary to check how Carthage handles such targets - we do not want to be forced to having e.g. visionOS simulator/SDK installed to be able to build for iOS.

On iOS 12 and lower, it is not supported to encode primitive values (such as String, Int or Codable objects that encode to single value using singleValueContainer) using JSONEncoder, this means that referenced line, where Encodable object is encoded, throws an error which is ignored.

So if I use code

final class Storage {
    @UserDefault("key", default: nil)
    var version: String?
}

let storage = Storage()
storage.version = "2.7.0"

Following error is thrown on iOS 12.4.1:

Swift.EncodingError.invalidValue(Optional("2.7.0"), Swift.EncodingError.Context(codingPath: [], debugDescription: "Top-level Optional<String> encoded as string JSON fragment.", underlyingError: nil))

This issue will remain present in old systems ➡️ https://bugs.swift.org/browse/SR-6163

I can think of multiple solutions:

• use different encoder/decoder than JSON - we would have to implement it as PropertyList causes the same issue which is probably too much work
• constraint our implementation for iOS 13+ as we might be able to check for supported types in UserDefaults but we will never catch cases when Codable object uses custom encode, that encodes object to singleValueContainer
• we could wrap the encoded value to Array or Dictionary (probably array would be better) so the encoder always has a root object

When changing dark mode settings, our uiImage.color() extension doesn't respect that - return image.withTintColor(color) on iOS 13 to address that.

As iOS 13 modals are not fullscreen and they can be closed by dragging, it would be necessary to check our logic of FlowCoordinators and then update them so especially flow coordinators that have a modally presented viewController as root, do not cause a leak.

Possible implementation might be using UIAdaptivePresentationControllerDelegate in the same way we use UINavigationControllerDelegate for UINavigationController.

So we can use it natively instead of our hack 🎉

Right now our view.safeArea property works on all systems, when using deployment target iOS 11+, it is not necessary and we should probably prefer the native safeAreaLayoutGuide.

So adding @available(iOS, deprecated: 11, renamed: "safeAreaLayoutGuide") on UIView and @available(iOS, deprecated: 13, renamed: "view.safeAreaLayoutGuide") on UIViewController should be added.

Currently we should be able to use the latest Xcode and we should also be able to reenable (disabled by #106) building Carthage artifact as XCFramework.

Right now if Localizable.strings is not part of main app bundle, String.localized() function doesn't work.

As TableHeaderFooterView inherits from UIView and not UITableViewHeaderFooterView, its readableContentGuide behaves differently from UITableViewCells.

It should definitely inherit from UITableViewHeaderFooterView but I think it would be better to make this change somehow breaking as UITableViewHeaderFooterView has e.g. defined background color. We should think about good breaking change that would force everyone to think about it.

As GradientView is by design not user interactive, it should have isUserInteractionEnabled = false. Add it to init as default.