achrome / conphig Goto Github PK

Increase unit test coverage to 100%

Use of the Singleton pattern is highly not recommended:

• The Singleton pattern introduces global state which
  • Makes it very hard for users of your library to test the code.
  • Makes applications who use it lie about their dependencies (The methods don't mention they need the Configuration class, but in fact, they do need it).

Instead, you should:

• Make the constructor public
• Get rid of static methods (and especially getInstance)
• Use proper DI and utilize the constructor's arguments.

For more information: The Clean Code Talks - Don't Look for Things!